Skip to content

fix(filesystem): resolve symlink/junction targets to directory type in readDirectoryEntries #28529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielxxomg wants to merge 3 commits into from
Closed

fix(filesystem): resolve symlink/junction targets to directory type in readDirectoryEntries #28529

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
784daa2
fix(mcp): persist disabled MCP state across config reloads
danielxxomg May 20, 2026
08b1301
fix(mcp): suppress noisy warning on first-run missing mcp-state.json
danielxxomg May 20, 2026
7b29ce7
fix(filesystem): resolve symlink/junction targets to directory type i…
danielxxomg May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(mcp): suppress noisy warning on first-run missing mcp-state.json 
NotFound is expected on first run — silence it. Still warn on actual errors like corrupt JSON or permission denied.
  • Loading branch information
@danielxxomg
danielxxomg committed May 20, 2026
commit 08b1301aac6cdcaef8d4e8e6da025199edeb79b1
5 changes: 4 additions & 1 deletion packages/opencode/src/mcp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,10 @@ export const layer = Layer.effect(
return new Set(obj.disabledMcpServerIds.filter((x): x is string => typeof x === "string"))
}),
Effect.catchCause((cause) => {
log.warn("failed to read mcp-state.json", { cause: Cause.squash(cause) })
const err = Cause.squash(cause)
if (err && typeof err === "object" && "_tag" in err && err._tag === "NotFound")
return Effect.succeed(new Set<string>())
log.warn("failed to read mcp-state.json", { cause: err })
return Effect.succeed(new Set<string>())
}),
Comment on lines +286 to +292
)
Expand Down
Loading