Skip to content

fix(opencode): add lsp sync range for roslyn and fix workspacesymbol query #23612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VladD2 wants to merge 9 commits into from
Closed

fix(opencode): add lsp sync range for roslyn and fix workspacesymbol query #23612

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
042e0e1
Fix bug #23075: LSP workspaceSymbol is always send with empty query
VladD2 Apr 21, 2026
247d7e0
Merge remote-tracking branch 'origin/dev' into vladd2-bug-23075-works…
VladD2 Apr 27, 2026
dfb4c65
Merge branch 'dev' into vladd2-bug-23075-workspace-symbol-empty-query
VladD2 Apr 27, 2026
b22ddc5
test(lsp): rewrite tests for required parameter validation
VladD2 Apr 27, 2026
cadc0dd
fix(lsp): merge dev refactoring with correct workspaceSymbol paramete…
VladD2 May 9, 2026
4c6e713
test(lsp): simplify workspaceSymbol test to only pass query
VladD2 May 10, 2026
3276f3b
Merge remote-tracking branch 'origin/dev' into vladd2-bug-23075-works…
VladD2 May 10, 2026
1170f19
Fix lsp.ts: remove unreachable workspaceSymbol check and move positio…
VladD2 May 10, 2026
fa306f5
Merge branch 'dev' into vladd2-bug-23075-workspace-symbol-empty-query
VladD2 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lsp.ts: remove unreachable workspaceSymbol check and move positio… 
…n vars after line/character validation
  • Loading branch information
@VladD2
VladD2 committed May 10, 2026
commit 1170f19213471cf43a1a37afae12859befdbaaa3
12 changes: 4 additions & 8 deletions packages/opencode/src/tool/lsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,7 @@ export const LspTool = Tool.define(
})

const uri = pathToFileURL(file).href
const position = { file, line: args.line - 1, character: args.character - 1 }
const relPath = path.relative(instance.worktree, file)
const detail =
args.operation === "workspaceSymbol"
? ""
: args.operation === "documentSymbol"
? relPath
: `${relPath}:${args.line}:${args.character}`
const title = detail ? `${args.operation} ${detail}` : args.operation

const exists = yield* fs.existsSafe(file)
if (!exists) throw new Error(`File not found: ${file}`)
Expand All @@ -103,6 +95,10 @@ export const LspTool = Tool.define(
throw new Error(`line and character are required for operation '${args.operation}'`)
}

const position = { file, line: args.line - 1, character: args.character - 1 }
const detail = `${relPath}:${args.line}:${args.character}`
const title = `${args.operation} ${detail}`

const result: unknown[] = yield* (() => {
switch (args.operation) {
case "goToDefinition":
Expand Down
Loading