Skip to content

fix(session): keep GitHub Copilot compaction requests valid #22371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 6 commits into from
Apr 14, 2026
Merged

fix(session): keep GitHub Copilot compaction requests valid #22371

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f327584
fix windows e2e backend not stopping on sigterm waiting 10s for no re…
Hona Apr 10, 2026
da2e91c
ci use node 24 in test workflow fixing random ECONNRESET (#21782)
Hona Apr 10, 2026
a3f5c5d
Merge remote-tracking branch 'upstream/dev' into dev
Hona Apr 13, 2026
987afa3
Merge remote-tracking branch 'upstream/dev' into dev
Hona Apr 13, 2026
03f80a4
fix(session): keep GitHub Copilot compaction requests valid
Hona Apr 14, 2026
7b0150e
fix(session): detect Copilot compat by provider
Hona Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix windows e2e backend not stopping on sigterm waiting 10s for no re… 
…ason (#21781)
  • Loading branch information
@Hona
Hona authored Apr 10, 2026
commit f327584e0ad13cbd39bc47753fec68b4b58cdc46
10 changes: 7 additions & 3 deletions packages/app/e2e/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,12 @@ async function waitForHealth(url: string, probe = "/global/health") {
throw new Error(`Timed out waiting for backend health at ${url}${probe}${last ? ` (${last})` : ""}`)
}

function done(proc: ReturnType<typeof spawn>) {
return proc.exitCode !== null || proc.signalCode !== null
}

async function waitExit(proc: ReturnType<typeof spawn>, timeout = 10_000) {
if (proc.exitCode !== null) return
if (done(proc)) return
await Promise.race([
new Promise<void>((resolve) => proc.once("exit", () => resolve())),
new Promise<void>((resolve) => setTimeout(resolve, timeout)),
Expand Down Expand Up @@ -123,11 +127,11 @@ export async function startBackend(label: string, input?: { llmUrl?: string }):
return {
url,
async stop() {
if (proc.exitCode === null) {
if (!done(proc)) {
proc.kill("SIGTERM")
await waitExit(proc)
}
if (proc.exitCode === null) {
if (!done(proc)) {
proc.kill("SIGKILL")
await waitExit(proc)
}
Expand Down
Loading