Repository navigation
fix(app): force SSE reconnect on tab refocus after long hidden duration - #19461
Closed
philstevenson wants to merge 1 commit into
Closed
philstevenson wants to merge 1 commit into
philstevenson wants to merge 1 commit into
Conversation
The onVisibility handler only checked lastEventAt against a 15s threshold, which missed cases where the tab was hidden long enough for the SSE connection to silently die but lastEventAt still appeared recent. Track when the tab was hidden and force reconnect if either the event stream is stale or the tab was hidden longer than the heartbeat timeout.
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
onVisibilityhandler inglobal-sdk.tsxonly checkedDate.now() - lastEventAt < HEARTBEAT_TIMEOUT_MSwhen the tab regained focus. This missed the common scenario where:Date.now() - lastEventAt= 12s < 15s — handler does nothingFix
Track
hiddenAtonvisibilitychange: hidden, then onvisibleforce reconnect if either condition is true:The downstream refresh flow (
server.connected→queue.refresh()→bootstrap()+ child directory re-bootstrap) already handles full state sync once the SSE reconnects. No other files need changes.Testing