Skip to content

fix: Add symlink setting (opt-in) to fix workflows relying on them #12992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeroenev wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: Add symlink setting (opt-in) to fix workflows relying on them #12992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/core/src/v1/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ export const Info = Schema.Struct({
description:
"Enable or disable snapshot tracking. When false, filesystem snapshots are not recorded and undoing or reverting will not undo/redo file changes. Defaults to true.",
}),
follow_symlinks: Schema.optional(Schema.Boolean).annotate({
description: "Follow symbolic links when searching files (default: false)",
}),
plugin: Schema.optional(Schema.mutable(Schema.Array(ConfigPluginV1.Spec))),
share: Schema.optional(Schema.Literals(["manual", "auto", "disabled"])).annotate({
description:
Expand Down
11 changes: 9 additions & 2 deletions packages/opencode/src/tool/glob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import path from "path"
import { Effect, Schema } from "effect"
import { Effect, Option, Schema } from "effect"
import { InstanceState } from "@/effect/instance-state"
import { Config } from "@/config/config"
import { FSUtil } from "@opencode-ai/core/fs-util"
import { Ripgrep } from "@opencode-ai/core/ripgrep"
import { assertExternalDirectoryEffect } from "./external-directory"
Expand Down Expand Up @@ -46,8 +47,14 @@ export const GlobTool = Tool.define(
kind: "directory",
})

const configSvc = yield* Effect.serviceOption(Config.Service)
const cfg = Option.isNone(configSvc)
? undefined
: yield* configSvc.value.get().pipe(Effect.catch(() => Effect.succeed(undefined)))
const follow = cfg?.follow_symlinks ?? false

const limit = 100
const files = yield* ripgrep.glob({ cwd: search, pattern: params.pattern, limit })
const files = yield* ripgrep.glob({ cwd: search, pattern: params.pattern, limit, follow })
const truncated = files.length === limit

const output = []
Expand Down
Loading