can you explain more what you mean by scrubbing the indentations? like you'd trim every line in the file, old string, new string and do the replace?

Great question! Sorry I wasn't very clear. If LLM passes back an "old string" to match on to replace of the following:

    const foo = "bar";
    const bar = "baz";

Then instead of looking for that string with the indentation, I would look for the following:

const foo = "bar";
const bar = "baz";

Now as you alluded to, you'd essentially have to trim the entire file indents too if you wanted to try and do a full string match on this successfully. But I thought that was excessive. So the way I did it is I start by iterating through the lines of the real file, trimming each line as I check it and look for a match to the first line provided by the LLM (const foo = "bar";) ... if I find a match at line 27 then I try matching lines 2...n (in my example above it would just be matching the next trimmed line of const bar = "baz";).

If there happened to be two of the same old strings in the file, this also by default would replace the first found occurrence so that you can instruct the user this is the expectation in the rare case they have the same content multiple times in the file.

TLDR:

Split the old string match coming from LLM into array of lines.
Trim the indentations from incoming LLM old string lines.
Loop through real file lines looking for a match to the first line coming from LLM (trimming to match).
When first line is found, then loop through the other lines provided to see if they also match trimmed.

The other thing to note is I actually instructed the LLM to provide its old content and new content info each as an array of lines to avoid needing to split the content string by line break.

Also I first actually checked for exact match and edited the file with exact match if found. I only did the trimming logic as a fallback if a match wasn't found.

Does this make sense? Let me know if you have any questions and also would be happy to review any code you put together.

gemini doesn't handle edit tool very well #266

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions