Skip to content

feat(chat): check the page after each reply and fix what it finds #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankit merged 7 commits into from
Oct 5, 2026
Merged

feat(chat): check the page after each reply and fix what it finds #1174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c2a0c5
feat(chat): check the page after each reply and fix what it finds
ankit Oct 5, 2026
ce1a565
refactor(chat): simplify the page check and the reply loop
ankit Oct 5, 2026
efd42cc
refactor(chat): split how a reply's calls combine into named steps
ankit Oct 5, 2026
f637e00
refactor(chat): shorten the prompt's guidance on fixing the page check
ankit Oct 5, 2026
bd2beab
feat(chat): report text a reply's variable made hard to read as one p…
ankit Oct 5, 2026
7564b03
refactor(chat): split the page check into a folder, one file per check
ankit Oct 5, 2026
211007e
refactor(chat): name each page check after what it finds
ankit Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(chat): split the page check into a folder, one file per check 
The color math gets its own module and tests; unreadable text, clashing
surfaces and declarations with no effect each get a file, and the eval
harness finds the check as a folder too.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
  • Loading branch information
@ankit @claude
ankit and claude committed Oct 5, 2026
commit 7564b0316a4829b49926bbfaffa671ed0c72a2c1
4 changes: 3 additions & 1 deletion evals/chat/bundles.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ const exists = (root, file) => fs.existsSync(path.join(root, file));
*/
const pageModule = (root, name) =>
[`src/features/page-bridge/chat/${name}`, `src/features/page-bridge/${name}`]
.filter(file => exists(root, `${file}.ts`))
.filter(
file => exists(root, `${file}.ts`) || exists(root, `${file}/index.ts`)
)
.map(file => path.join(root, file))[0] ?? null;

/**
Expand Down
Loading
Loading