Conversation
Point developers at field identity tracking and cover the original transformed collection reset failure.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JeanMeche
reviewed
Sep 13, 2026
JeanMeche
reviewed
Sep 13, 2026
JeanMeche
reviewed
Sep 13, 2026
JeanMeche
requested changes
Sep 13, 2026
Move @for tracking guidance into the error encyclopedia and mark NG01904 as documented. Relates to angular#70692
Document field-identity tracking with object rows, and clarify that reset through transformedValue format allocates fresh objects.
Author
|
@JeanMeche Resolved all comments, pls review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a previous field from a Signal Forms array becomes orphaned, NG01904 only reports that the element can no longer be found. It does not explain the supported
@fortracking pattern, and it is not linked from the Error Encyclopedia.This is particularly confusing in #70692, where a tracking expression such
as
track rowField().value().scorereads the previous orphaned field during@forreconciliation.Issue Number: #70692
What is the new behavior?
NG01904 is marked as documented (
-1904). The runtime message stays short and now links to a new Error Encyclopedia page:adev/src/content/reference/errors/NG01904.mdThat page explains array-of-object identity, the
@fortrack fieldcontract, and the case where areset()flows throughtransformedValue()andformat()allocates fresh objects.Does this PR introduce a breaking change?
Other information
Relates to #70692.