Skip to content

refactor(devtools): introduce a global backend config - #70617

Open
hawkgs wants to merge 2 commits into
angular:mainfrom
hawkgs:devtools/be-config
Open

hawkgs wants to merge 2 commits into
angular:mainfrom
hawkgs:devtools/be-config

Conversation

@hawkgs

@hawkgs hawkgs commented Sep 8, 2026

Copy link
Copy Markdown
Member

Unify the multiple scattered feature-specific flags into a single global backend config.

The PR also fixes a pre-existing bug where the saved settings are not applied on DevTools initialization in prod mode, due to an effect init happening before the FE and BE establishing a connection. This affected the recently added CD highlighting, the performance track and the hydration overlays. However, the issue got masked for hydration overlays option pre-#70567, since it used a different refresh mechanism.

@ngbot ngbot Bot added this to the Backlog milestone Sep 8, 2026
@hawkgs
hawkgs force-pushed the devtools/be-config branch 3 times, most recently from 60b29b7 to c4981b8 Compare September 10, 2026 10:20
@hawkgs
hawkgs marked this pull request as ready for review September 10, 2026 10:25
@hawkgs
hawkgs requested review from JeanMeche and dgp1130 September 10, 2026 10:34
- Unify the multiple scattered feature-specific flags into a single
global backend config
- Fix initial settings data exchange between the fe and be on prod

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGENT: I have left an inline suggestion for your consideration regarding a potential memory leak with the configuration listeners.

Comment thread devtools/projects/ng-devtools-backend/src/lib/client-event-subscribers.ts Outdated

@dgp1130 dgp1130 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Agreed it's nice to consolidate these feature flags into a single implementation.

Comment thread devtools/projects/ng-devtools-backend/src/lib/config/config.ts
Comment thread devtools/projects/ng-devtools-backend/src/lib/config/config.ts Outdated
@hawkgs hawkgs added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DevTools does not restore change detection data after a page reload

3 participants