Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

@Rest doesn't encode all parameters #1677

Description

@jpelgrom

When using a @Rest interface with a method that takes URL parameters, such as:

@Get("/search/keyword/{keyword}/mode/{mode}")
public SearchResponse search(String keyword, String mode);

Using any characters that are considered safe for use in URLs, such as / and &, these characters will not be encoded. For example, search("any/key", "alpha") will result in the following URL:

/search/keyword/any/key/mode/alpha

Which obviously will result in an error, because now the parameters are "any" and "mode". Expected behaviour: the URL parameters are escaped, like this:

/search/keyword/any%2Fkey/mode/alpha

Encoding the parameter in my own code doesn't solve this issue, because %2F wil be encoded in to %252F. Changing the input from String to android.net.Uri or java.net.URI to prevent encoding also doesn't make any difference. Using the Spring RestTemplate, you could just pass an UriTemplate to prevent encoding, but that doesn't seem to be possible here.

Is it possible to either force it to encode everything in the parameter, as I'd expect, or force it not to encode anything, so that the user would have to encode it?

Using AA 3.3.2 and Spring Android REST template 2.0.0M3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions