Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Since
RestoreCredentialandPublicKeyCredentialare sibling subclasses ofCredential, the restore branch nested insideif (credential is PublicKeyCredential)is unreachable: the retrieved assertion is never sent to the relying party and the call fails silently withAuthResult.Failure(AuthError.Unknown(null)).WHAT
This PR makes the check accept
RestoreCredential. I've confirmed the behavior on a Pixel 8a, as the attached capture shows:POST /webauthn/signinResponsereturns 200 and the app reaches the home screen with no interaction, where before onlysigninRequestwas sent.selfqa2_trimmed_1.5x.mov