Skip to content

Improve maven.yml - #538

Merged
andymckay merged 1 commit into
actions:masterfrom
Marcono1234:patch-1
Nov 25, 2020
Merged

andymckay merged 1 commit into
actions:masterfrom
Marcono1234:patch-1

Conversation

@Marcono1234

@Marcono1234 Marcono1234 commented Jun 3, 2020 •

Copy link
Copy Markdown
Contributor

Changes:

  • Write out -B as --batch-mode to make it easier to understand or searchable by users not familiar with all Maven command line options
  • Remove --file pom.xml because it is the default anyways. Or does it exist to indicate how users could specify a different file?
  • Add --update-snapshots to force update snapshots (otherwise it might use stale versions), see this StackOverflow question asking about the behavior. Note that this overwrites locally installed packages, but should probably not be an issue for the great majority of projects.
  • Run all phases up to including verify (instead of package only) to also run integration tests

Note that GitHub Help: Building and testing Java with Maven would have to be updated accordingly.

For further reading:

@github-actions

Copy link
Copy Markdown

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

@Marcono1234

Copy link
Copy Markdown
Contributor Author

Bad bot! :(

@Marcono1234 Marcono1234 mentioned this pull request Nov 25, 2020

@andymckay andymckay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇🏾 and sorry for being slow to getting to this. The docs links in the issue help, because I don't know much about maven, so its good to read up on it.

@andymckay
andymckay merged commit c088288 into actions:master Nov 25, 2020
@andymckay

Copy link
Copy Markdown
Contributor

Opened an PR over here: github/docs#1609 the docs are open source now 😄 👍🏾

@Marcono1234
Marcono1234 deleted the patch-1 branch November 25, 2020 21:10
@Marcono1234

Marcono1234 commented Nov 25, 2020 •

Copy link
Copy Markdown
Contributor Author

No worries and thanks for the link / follow-up pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants