Skip to content

New Ruby Gem publish workflow to replace Ruby Push - #184

Closed
clarkbw wants to merge 7 commits into
actions:masterfrom
clarkbw:rubygems-publish
Closed

New Ruby Gem publish workflow to replace Ruby Push#184
clarkbw wants to merge 7 commits into
actions:masterfrom
clarkbw:rubygems-publish

Conversation

@clarkbw

@clarkbw clarkbw commented Nov 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for sending in this pull request. Please make sure you take a look at the contributing file. Here's a few things for you to consider in this pull request:

  • Include a good description of the workflow.
  • Links to the language or tool will be nice (unless its really obvious)

In the workflow and properties files:

  • Includes a matching ci/properties/*.properties.json file.
  • Use title case for the names of workflows and steps, for example "Run tests".
  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
  • Include comments in the workflow for any parts that are not obvious or could use clarification.
  • CI workflows should run push.
  • Packaging workflows should run on release with types: [created].
    • Push to tag

Some general notes:

  • Does not use an Action that isn't in the actions organization.
  • Does not send data to any 3rd party service except for the purposes of installing dependencies.
  • Does not use a paid service or product.

@clarkbw clarkbw changed the title Create rubygems-publish.yml New Ruby Gem publish workflow to replace Ruby Push Nov 5, 2019
mscoutermarsh
mscoutermarsh approved these changes Nov 8, 2019
View reviewed changes

@mscoutermarsh mscoutermarsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

Before merging, could you bring back the gem-push files? Or have these replace gem-push? We link to them on dotcom and the links would be broken until we sync them.

@clarkbw

clarkbw commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

Ok, can do!

@clarkbw

clarkbw commented Nov 14, 2019

Copy link
Copy Markdown
Contributor Author

I think this is a ready to merge better alternative.

I wanted to replace the original files but they are awkwardly named starting w/ gem instead of ruby. Happy to delete them once the docs have been updated.

@clarkbw clarkbw closed this Nov 14, 2019
@clarkbw clarkbw reopened this Nov 14, 2019
ghost referenced this pull request Feb 17, 2020
@josh @myobie
Add Docker push to GitHub Package Registry
8c3d01f 
Co-authored-by: Nathan Herald <[email protected]>
@github-actions

github-actions Bot commented Nov 25, 2020

Copy link
Copy Markdown

This pull request has become stale and will be closed automatically within a period of time. Sorry about that.

@github-actions github-actions Bot closed this Dec 2, 2020
@clarkbw
clarkbw deleted the rubygems-publish branch December 2, 2020 17:59
@nexoracontrol-ops nexoracontrol-ops mentioned this pull request Sep 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mscoutermarsh mscoutermarsh mscoutermarsh approved these changes
@barroombrown barroombrown barroombrown approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-pr-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clarkbw @mscoutermarsh @barroombrown