Skip to content

Bringing back Datadog Synthetics workflow - #1503

Merged
bishal-pdMSFT merged 2 commits into
mainfrom
revert-1385-revert-1342-dd-synthetics-action
Mar 25, 2022
Merged

bishal-pdMSFT merged 2 commits into
mainfrom
revert-1385-revert-1342-dd-synthetics-action

Conversation

@bishal-pdMSFT

@bishal-pdMSFT bishal-pdMSFT commented Mar 25, 2022 •

Copy link
Copy Markdown

Reverts removal of Datadog Synthetics workflow #1385

The only change as compared to original workflow is that a creator fields has been added in properties.json which points out to Datadog

@bishal-pdMSFT
bishal-pdMSFT requested a review from a team as a code owner March 25, 2022 10:15
@bishal-pdMSFT bishal-pdMSFT mentioned this pull request Mar 25, 2022
23 tasks
@Phantsure

Copy link
Copy Markdown
Contributor

Can we add permissions? Otherwise looks good

permissions:
  contents: read

@bishal-pdMSFT

Copy link
Copy Markdown
Author

Good point, but to be honest I am not sure what all permissions this workflow needs. @peculiarism would be better person to answer that.
Lets de-couple that change and take separately. I will create an issue for that.

@bishal-pdMSFT

Copy link
Copy Markdown
Author

Issue to track adding permissions: #1504

@bishal-pdMSFT
bishal-pdMSFT merged commit e59567a into main Mar 25, 2022
@bishal-pdMSFT
bishal-pdMSFT deleted the revert-1385-revert-1342-dd-synthetics-action branch March 25, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants