Skip to content

Starter workflow Symfony - #1069

Merged
ashwinsangem merged 17 commits into
actions:mainfrom
TheGarious:starter_workflow_symfony
Sep 28, 2021
Merged

ashwinsangem merged 17 commits into
actions:mainfrom
TheGarious:starter_workflow_symfony

Conversation

@TheGarious

@TheGarious TheGarious commented Aug 30, 2021 •

Copy link
Copy Markdown
Contributor

Pre-requisites

  • Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

@TheGarious
TheGarious requested a review from a team as a code owner August 30, 2021 20:29
@TheGarious TheGarious mentioned this pull request Sep 4, 2021
Comment thread ci/symfony.yml Outdated
Comment thread ci/symfony.yml
@NinadKavimandan

Copy link
Copy Markdown
Contributor

@TheGarious the template looks good. But is there anything particular to Symfony in this template, other than what's being done in the default PHP template?

@TheGarious
TheGarious requested review from joshmgross and removed request for a team September 14, 2021 20:35
Comment thread ci/properties/symfony.properties.json
@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, can you confirm to @NinadKavimandan 's comment

@TheGarious

Copy link
Copy Markdown
Contributor Author

@ashwinsangem i add specific command from symfony installation.

@tang5551

tang5551 commented Sep 19, 2021 via email

Copy link
Copy Markdown

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious Great. Can you point me to one Symfony repo where you used this workflow successfully?

@tang5551

tang5551 commented Sep 19, 2021 via email

Copy link
Copy Markdown

@ashwinsangem ashwinsangem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tang5551

tang5551 commented Sep 19, 2021 via email

Copy link
Copy Markdown

@TheGarious

Copy link
Copy Markdown
Contributor Author

@tang5551 who are you ?

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, can you point me to one Symfony repo where you used this workflow successfully?

@ashwinsangem
ashwinsangem merged commit f0b8c8a into actions:main Sep 28, 2021
@TheGarious

Copy link
Copy Markdown
Contributor Author

@ashwinsangem Sorry i didn't see your message. I can show you in public repository.

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, great, please link one here, thank you😊

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, Also, how to identify if a given repo has Laravel or Symfony? I'll need your help there.

@TheGarious

Copy link
Copy Markdown
Contributor Author

@ashwinsangem For identify if a given repo has Laravel or Symfony, we need to read a composer.json into "require" for each project.
For Laravel Project we have got "laravel/framework".
For Symfony Project we have got "symfony/framework-bundle".

@ashwinsangem

Copy link
Copy Markdown
Contributor

That's nice. @TheGarious, can you create an issue in this repo. It'll help us add the support for recognizing these tech_stacks(laravel, symfony) for a repo. Post that, this template would start showing as a recommendation as part of actions/new

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, gentle reminder.

@TheGarious

Copy link
Copy Markdown
Contributor Author

@ashwinsangem i submit 2 issues into your linked repo, for symfony and laravel.

@ashwinsangem

Copy link
Copy Markdown
Contributor

@TheGarious, thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants