feat: update conversational agent sample app with personal connection polling by norman-le · Pull Request #800 · UiPath/uipath-typescript

norman-le · 2026-10-02T19:32:09Z

uipath-typescript

feat/jar-10826-cas-personal-connections-parity-widgets — adds getConnectionAuthUrl() and getConnectionSessionStatus() (both @internal) #798

sessionId added to ConnectionAuthResponse
getConnectionSessionStatus() — new method to poll OAuth session completion
ConnectionSessionStatusResponse type — pending | success | failed
CONNECTION_SESSION_STATUS endpoint
@internal caveat on all 4 connection methods (require user-scoped tokens)

Sample app branch (feat/jar-10826-sample-app-polling) — ConnectionsPanel polling fix (setInterval → setTimeout), new ConnectionReadinessCard, ChatArea stale-response guard, isConfigurable filtering.

Blocked until SDK publishes.
feat: update conversational agent sample app with personal connection polling #800

uipath-ui-widgets — `feat/jar-10826-cas-personal-connections-parity-widgets`

Porting CAS personal connections UI: UiPath/uipath-ui-widgets#171

ConnectionReadinessCard — 3 states (collapsed/yellow/red), OAuth polling at 500ms for connect buttons, auto-collapse
ConnectionsSection — settings tab with connection picker, search, grouped by personalWorkspace/folder, dirty tracking, save/cancel, OAuth flow with auth fallback
ConversationalAgentChat — fetches readiness on agent init, agent start-up autobinding, race condition guard, clears on send/new chat
SettingsDialog — ConnectionsSection accordion item

Known Limitations (not code bugs)

Save fails in standalone sample app — external app token lacks OrchestratorApiUserAccess audience, causing Orchestrator's SetResourceUserOverwrites to reject. Should work fine when widgets runs inside the CAS platform with the platform token.

- URL-encode sessionId in CONNECTION_SESSION_STATUS endpoint - Serialize polling in JSDoc example (setTimeout instead of setInterval) - Add console.warn to silent catch in getAddConnectionUrl Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Sample app updates depend on unreleased SDK APIs (sessionId, getConnectionSessionStatus). Moving to a follow-up PR after the SDK version is published. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

All sample app updates moved to feat/jar-10826-sample-app-polling branch for a follow-up PR after the SDK version is published. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

- Add cancellation guards for stale agent responses (ChatArea, ConnectionsPanel) - Serialize polling with recursive setTimeout (ConnectionsPanel) - Resolve connection state by currentConnectionId, not any enabled connection - Filter broken/auto-save lists by isConfigurable (ConnectionReadinessCard) - Disable all Connect buttons while any OAuth flow is active - Fix "X of Y connections still needed" count - Add console.warn to all silent catches Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Copilot

Copilot review overview

🟡 Changes recommended

Polling races, stale agent handling, incorrect state mapping, and premature success state can produce incorrect or duplicate updates.

Review effort: Balanced
Findings: 3

Open (3)

What changed in this PR

Updates the conversational-agent sample app with personal connection readiness and OAuth polling.

Changes:

Adds in-chat connection readiness UI.
Adds OAuth session polling and connection refresh.
Guards stale readiness responses and filters configurable connections.

File	Description
`ConnectionsPanel.tsx`	Adds connection creation polling and refresh.
`ConnectionReadinessCard.tsx`	Adds readiness states, OAuth flow, polling, and auto-binding.
`ChatArea.tsx`	Fetches and displays connection readiness.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

claude · 2026-10-02T19:36:37Z

Review summary — one issue flagged inline on ConnectionReadinessCard.tsx:147: stale localConnectors closure in the auto-save payload. The setInterval callback captures localConnectors from the useCallback closure at the time startOAuthFlow runs. If the visibilitychange handler refreshes state between when polling starts and when the success tick fires, updateConnectionSelections sends stale connection IDs for every connector other than the one just connected. Suggested fix: mirror state into a localConnectorsRef and read from the ref inside the interval callback.

Copilot

Copilot review overview

🟡 Changes recommended

Polling races and stale state can duplicate updates, overwrite selections, or discard unsaved changes.

Review effort: Balanced
Findings: 1

Open (1)

Slow initial request overwrites newer readiness result · New

Resolved since last review (3)

Previously missed (2)

In code that hasn't changed since last review

Stale auth callbacks persist after target identity changes

samples/conversational-agent-app/src/components/ConnectionReadinessCard.tsx:79

Clearing the timer alone does not invalidate an already-running auth or status request, and this effect never reruns when agentId/folderId changes. The old callback can consequently auto-save and replace readiness after the card has switched agents. Invalidate the session during cleanup and reset the connecting state whenever the target identity changes.

This issue also appears in the following locations of the same file:

line 135
line 155

OAuth callback discards unsaved staged selections

samples/conversational-agent-app/src/components/ConnectionsPanel.tsx:96

Using load as the OAuth-success callback silently discards any unsaved picker changes: useConnections.load() replaces both initialSelections and stagedSelections with the server response. If a user changes one row and then adds a connection from another, the first change disappears. Refresh the available connection lists while preserving staged selections (or explicitly merge them) instead of invoking the resetting load path.

This issue also appears on line 164 of the same file.

claude · 2026-10-02T19:51:45Z

Review summary — 2 new findings posted as inline comments:

ConnectionReadinessCard.tsx:135 — setInterval with async callback can overlap. The PR description calls out a setInterval-to-setTimeout fix for ConnectionsPanel; the new ConnectionReadinessCard repeats the same pattern. On slow networks, two interval ticks can both observe a success response and both call updateConnectionSelections, causing a double-save race. Fix: convert to recursive setTimeout as done in ConnectionsPanel.
ChatArea.tsx:77 — silent catch. All other catches in this file call console.warn; this one swallows the error from the deferred re-fetch silently, making failures invisible in dev tooling.

… bind

Copilot

Copilot review overview

🟡 Changes recommended

OAuth races and error paths can discard or overwrite selections and incorrectly hide readiness prompts.

Review effort: Balanced
Findings: 1

Open (1)

Preserve initial readiness when delayed refresh fails · New

Resolved since last review (1)

Slow initial request overwrites newer readiness result

Previously missed (2)

In code that hasn't changed since last review

Invalidate pending OAuth flows during cleanup

samples/conversational-agent-app/src/components/ConnectionReadinessCard.tsx:78

Cleanup clears an existing interval but does not invalidate a pending OAuth flow. If the component unmounts while getConnectionAuthUrl is awaiting, its continuation still passes the session check, opens a tab, and creates a new interval after cleanup has already run. Increment oauthSessionRef during cleanup so pending continuations return without side effects.

This issue also appears in the following locations of the same file:

line 157
line 175

Refresh connections without discarding unsaved selections

samples/conversational-agent-app/src/components/ConnectionsPanel.tsx:96

Refreshing via load after OAuth completion replaces both initialSelections and stagedSelections with server values (useConnections.ts:40-44). If the user has unsaved edits in another row, creating a connection silently discards them. Refresh the available connection list while preserving/merging staged selections instead of invoking the resetting load path.

This issue also appears on line 164 of the same file.

claude · 2026-10-02T21:05:23Z

+      // Fallback to the platform URL if auth endpoint isn't available
+      const url = await conversationalAgent.getAddConnectionUrl(item)
+      if (url) window.open(url, '_blank', 'noopener,noreferrer')


Unhandled rejection: getAddConnectionUrl is an await inside a catch block with no surrounding try. If it throws, the error propagates out of the outer catch, and since handleAddConnection is called from a button onClick with no .catch() wrapper, the rejection goes unhandled and shows up as an error in the console.

Wrap the fallback in its own try/catch:

Suggested change

// Fallback to the platform URL if auth endpoint isn't available

const url = await conversationalAgent.getAddConnectionUrl(item)

if (url) window.open(url, '_blank', 'noopener,noreferrer')

try {

const url = await conversationalAgent.getAddConnectionUrl(item)

if (url) window.open(url, '_blank', 'noopener,noreferrer')

} catch (fallbackError) {

console.warn('Failed to open platform connections URL:', fallbackError)

}

claude · 2026-10-02T21:05:29Z

Review summary — 1 new finding:

ConnectionsPanel.tsx:195–197 — unhandled rejection in fallback path. getAddConnectionUrl is awaited inside a catch block with no try/catch of its own. If it throws, the error escapes the outer catch and becomes an unhandled promise rejection from the button's onClick handler. Fix: wrap in a nested try/catch with a console.warn.

claude · 2026-10-02T21:16:39Z

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

claude · 2026-10-02T21:20:15Z

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

Copilot

🟡 Changes recommended

Polling lifecycle races and unsafe state refresh/update behavior can overwrite or misrepresent connection selections.

4 open findings

1 resolved since last review

Preserve initial readiness when delayed refresh fails

🧠 Review effort: Balanced

+  // Cleanup polling on unmount
+  useEffect(() => {
+    return () => { clearPoll() }
+  }, [clearPoll])


+              await conversationalAgent.updateConnectionSelections(agentId, folderId, {
+                selections: localConnectorsRef.current.filter(c => c.isConfigurable).map(c => ({
+                  connectorKey: c.connectorKey,
+                  connectionId: c.connectorKey === connectorKey ? status.connectionId : c.currentConnectionId,
+                })),
+              })


+              // Fallback: optimistically update just the connected connector
+              if (oauthSessionRef.current === oauthSession) {
+                updateLocalConnectors(prev =>
+                  prev.map(c =>
+                    c.connectorKey === connectorKey
+                      ? { ...c, currentConnectionId: status.connectionId, currentConnectionState: 'Enabled' as const }
+                      : c,


+  useEffect(() => {
+    const handler = () => {
+      if (document.visibilityState !== 'visible') return
+      if (isLoading || isSaving) return
+      load()
+    }
+    document.addEventListener('visibilitychange', handler)
+    return () => document.removeEventListener('visibilitychange', handler)
+  }, [load, isLoading, isSaving])


claude · 2026-10-07T16:36:51Z

✅ No issues found. Checked for bugs and CLAUDE.md compliance.

sonarqubecloud · 2026-10-07T16:38:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

norman-le and others added 7 commits October 1, 2026 16:01

feat: add connection status for polling to be used in widgets

f13ee32

fix: various fixes on feedback around connection cards and polling

a3bfad8

chore: revert sample app changes to separate PR

6d5f352

Sample app updates depend on unreleased SDK APIs (sessionId, getConnectionSessionStatus). Moving to a follow-up PR after the SDK version is published. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

chore: revert all sample app changes to main state

d09e146

All sample app updates moved to feat/jar-10826-sample-app-polling branch for a follow-up PR after the SDK version is published. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

chore: update and jsdoc and test

1ee6c6f

Copilot AI balanced review requested due to automatic review settings October 2, 2026 19:32

norman-le mentioned this pull request Oct 2, 2026

feat: add connection status for polling to be used in widgets #798

Merged

Copilot started reviewing on behalf of norman-le October 2, 2026 19:32 View session

norman-le mentioned this pull request Oct 2, 2026

feat: cas chat parity for personal connections UiPath/uipath-ui-widgets#171

Open

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ChatArea.tsx Outdated

Comment thread samples/conversational-agent-app/src/components/ConnectionReadinessCard.tsx Outdated

Comment thread samples/conversational-agent-app/src/components/ConnectionsPanel.tsx

claude Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ConnectionReadinessCard.tsx Outdated

refactor: address pr comments to match widgets behavior

ef71350

norman-le requested a balanced review from Copilot October 2, 2026 19:44

Copilot started reviewing on behalf of norman-le October 2, 2026 19:45 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ChatArea.tsx Outdated

claude Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ConnectionReadinessCard.tsx

claude Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ChatArea.tsx Outdated

refactor: reduce race condition possibility by making sequential auto…

1a34afc

… bind

norman-le requested a balanced review from Copilot October 2, 2026 20:56

Copilot started reviewing on behalf of norman-le October 2, 2026 20:57 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread samples/conversational-agent-app/src/components/ChatArea.tsx Outdated

claude Bot reviewed Oct 2, 2026

View reviewed changes

norman-le added 2 commits October 2, 2026 17:10

refactor: cleanup code

8f91c70

chore: handler to check after oauth in new tab is done

3e8173c

maninder-uipath approved these changes Oct 5, 2026

View reviewed changes

Base automatically changed from feat/jar-10826-cas-personal-connections-parity-widgets to main October 7, 2026 16:27

norman-le requested a review from a team October 7, 2026 16:27

Merge branch 'main' into feat/jar-10826-sample-app-polling

7ad9314

norman-le requested a balanced review from Copilot October 7, 2026 16:31

Copilot started reviewing on behalf of norman-le October 7, 2026 16:32 View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Conversation

norman-le commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

uipath-typescript

uipath-ui-widgets — feat/jar-10826-cas-personal-connections-parity-widgets

Known Limitations (not code bugs)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot commented Oct 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot commented Oct 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

claude Bot Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Oct 2, 2026

Uh oh!

claude Bot commented Oct 2, 2026

Uh oh!

claude Bot commented Oct 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

claude Bot commented Oct 7, 2026

Uh oh!

sonarqubecloud Bot commented Oct 7, 2026

Quality Gate passed

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

norman-le commented Oct 2, 2026 •

edited

Loading

uipath-ui-widgets — `feat/jar-10826-cas-personal-connections-parity-widgets`