test(overrides): pin the sdk_options guard on the registry, not its c…

…ontents Three tests matched the literal "claude-code, delegate agents". With a plugin installed that registers another kind with sdk_options, such as coder_eval_uipath's studio-web, the message lists more kinds and the tests fail. Match the fixed part of the message instead. Add a test that a throwaway registered kind whose config declares sdk_options accepts -D agent.sdk_options.*. This is the generic contract that lets coder_eval_uipath remove its override patch. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Mihaiii · Oct 6, 2026 · Sep 29, 2026 · Sep 29, 2026 · Sep 29, 2026 · Sep 29, 2026
commit 404b09949fa1f5e42fbe532395d4c793b11d5078
@@ -306,7 +306,7 @@ def test_system_prompt_file_override_clears_sibling(self):
 
     def test_sdk_options_on_codex_raises_friendly(self):
         task = _live_task(agent={"type": "codex"})
-        with pytest.raises(OverrideError, match="only supported for claude-code, delegate agents"):
+        with pytest.raises(OverrideError, match=r"agent type codex\. This option is only supported for "):
             apply_overrides(task, {"agent.sdk_options.effort": "high"})
 
     def test_lineage_cli_source_for_touched_paths_only(self):

@@ -144,17 +144,42 @@ def test_agent_type_injection_switches_subclass(self):
 
     def test_sdk_options_on_codex_raises(self):
         task = _make_task(agent=parse_agent_config(type="codex"))
-        with pytest.raises(OverrideError, match="only supported for claude-code, delegate agents"):
+        with pytest.raises(OverrideError, match=r"agent type codex\. This option is only supported for "):
             apply_overrides(task, {"agent.sdk_options.effort": "high"})
 
     def test_sdk_options_effort_on_delegate_applies(self):
         task = _make_task(agent=parse_agent_config(type="delegate"))
         apply_overrides(task, {"agent.sdk_options.effort": "high"})
         assert task.agent.sdk_options == {"effort": "high"}
 
+    def test_sdk_options_applies_to_any_registered_kind_that_declares_it(self):
+        """A plugin kind whose config declares ``sdk_options`` passes the guard, not only the built-ins."""
+        from typing import Any, Literal
+
+        from pydantic import Field
+
+        from coder_eval.agents.registry import AgentRegistry
+        from coder_eval.models import BaseAgentConfig
+
+        class _PluginConfig(BaseAgentConfig):
+            type: Literal["sdk-options-plugin"]  # type: ignore[assignment]
+            sdk_options: dict[str, Any] = Field(default_factory=dict)
+
+        class _PluginAgent:
+            def __init__(self, config, route=None, **kwargs):
+                self.config = config
+
+        AgentRegistry.register("sdk-options-plugin", _PluginConfig)(_PluginAgent)
+        try:
+            task = _make_task(agent=parse_agent_config(type="sdk-options-plugin"))
+            apply_overrides(task, {"agent.sdk_options.mode": "fast"})
+            assert task.agent.sdk_options == {"mode": "fast"}
+        finally:
+            AgentRegistry._registry.pop("sdk-options-plugin", None)
+
     def test_sdk_options_with_agent_type_codex_raises(self):
         task = _make_task(agent=parse_agent_config(type="claude-code"))
-        with pytest.raises(OverrideError, match="only supported for claude-code, delegate agents"):
+        with pytest.raises(OverrideError, match=r"agent type codex\. This option is only supported for "):
             apply_overrides(task, {"agent.sdk_options.effort": "high"}, agent_type="codex")
 
     def test_unknown_root_raises(self):