test(lint): drop a personal path and de-duplicate the isolation pin

No test datum should carry a developer's home directory. The repo-root case now uses `/home/dev/src/exp/coder_eval/conftest.py`, which keeps the shape that mattered — a `src` component that is NOT the package's parent, so it exercises the anchor rather than merely the absence of `src`. `ISOLATION` and a verbatim three-line docstring were copied into both the CE004 and CE066 test classes. Hoisted to one module-level `CORE_ISOLATION` with the rationale stated once, so the two pins cannot drift to different paths. Verified the pins still bite: re-exempting `isolation/` in `_NON_CORE` fails four tests. Also renames `test_ce008_skips_files_outside_scope` to `ce009` — it sits in the CE009 block and exercises `YamlModelsForbidExtras` (CE009), while CE008's own tests cover `ReadTextExplicitEncoding`. Pre-existing mislabel, flagged in review. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
uipreliga · Sep 16, 2026 · Sep 15, 2026 · Sep 15, 2026 · Sep 15, 2026 · Sep 15, 2026
commit c7c5baa259fd9ba244758de0ebb905562451d3ed
@@ -2096,6 +2096,14 @@ def test_task_rubric_is_bundled_and_read_by_its_readers(self):
             )
 
 
+# The `driver: docker` evaluation path, and the reason the core-layer predicate
+# became an allowlist: the directory-list form it replaced named ten packages and
+# `isolation` was not one, so the driver that runs the whole evaluation loop in a
+# container was invisible to BOTH layering rules. Shared, so the two pins below
+# cannot drift to different paths.
+CORE_ISOLATION = "/repo/src/coder_eval/isolation/docker_runner.py"
+
+
 @pytest.mark.lint
 class TestCE004CatchesBothImportSpellings:
     """CE004 must fire on the RELATIVE form, not only `coder_eval.cli`.
@@ -2138,13 +2146,8 @@ def test_a_non_cli_import_does_not_violate(self, source):
     def test_a_non_core_file_is_exempt(self):
         assert not self._violations("from ..cli import run_command", "/repo/src/coder_eval/cli/report_command.py")
 
-    ISOLATION = "/repo/src/coder_eval/isolation/docker_runner.py"
-
     def test_the_docker_driver_is_core(self):
-        """`isolation/` was in neither rule's reach: the directory-list predicate
-        named ten packages and `isolation` was not one, so the driver that runs
-        the whole evaluation loop in a container could import anything."""
-        assert self._violations("from ..cli import run_command", self.ISOLATION)
+        assert self._violations("from ..cli import run_command", CORE_ISOLATION)
 
 
 @pytest.mark.lint
@@ -2223,14 +2226,9 @@ def test_wholesale_module_import_into_core_violates(self):
     def test_a_non_core_file_is_exempt(self):
         assert not self._violations("from coder_eval.reports import format_score", self.NON_CORE)
 
-    ISOLATION = "/repo/src/coder_eval/isolation/docker_runner.py"
-
     def test_the_docker_driver_is_core(self):
-        """`isolation/` was in neither rule's reach: the directory-list predicate
-        named ten packages and `isolation` was not one, so the driver that runs
-        the whole evaluation loop in a container could import anything."""
-        assert self._violations("from ..reports import format_score", self.ISOLATION)
-        assert not self._violations("from ..reports import write_task_html", self.ISOLATION)
+        assert self._violations("from ..reports import format_score", CORE_ISOLATION)
+        assert not self._violations("from ..reports import write_task_html", CORE_ISOLATION)
 
     def test_every_allowlisted_name_resolves_in_the_package(self):
         """Staleness guard: a renamed writer must not leave a dead entry silencing
@@ -2324,7 +2322,11 @@ def test_every_module_is_classified_by_its_top_level_package(self):
 
     @pytest.mark.parametrize(
         "path",
-        ["/Users/religa/src/exp/coder_eval/conftest.py", "/home/dev/projects/coder_eval/conftest.py"],
+        [
+            # A `src` component that is NOT the package's parent, and none at all.
+            "/home/dev/src/exp/coder_eval/conftest.py",
+            "/home/dev/projects/coder_eval/conftest.py",
+        ],
     )
     def test_a_repo_root_file_is_not_core(self, path):
         """The checkout directory is itself named `coder_eval`, so the unanchored

@@ -484,7 +484,7 @@ def test_ce009_allows_subclass_inheriting_forbid_from_same_file(tmp_path: Path)
     assert violations == []
 
 
-def test_ce008_skips_files_outside_scope(tmp_path: Path) -> None:
+def test_ce009_skips_files_outside_scope(tmp_path: Path) -> None:
     """Files outside tasks.py / criteria.py are not flagged (results.py uses extra='allow')."""
     from tests.lint.rules.yaml_models_forbid_extras import YamlModelsForbidExtras