Skip to content

feat(apollo-wind): add a none variant to Input [MST-16240] - #1300

Open
KodudulaAshishUiPath wants to merge 1 commit into
mainfrom
feat/MST-16240-input-unstyled
Open

feat(apollo-wind): add a none variant to Input [MST-16240]#1300
KodudulaAshishUiPath wants to merge 1 commit into
mainfrom
feat/MST-16240-input-unstyled

Conversation

@KodudulaAshishUiPath

@KodudulaAshishUiPath KodudulaAshishUiPath commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds variant="none" to Input: no border, background or shadow, and no Future-theme overrides, for a caller whose className draws its own box.
  • Today the Future block (future:h-10 future:rounded-xl future:border-0 future:bg-surface-overlay ...) applies to every default-variant, default-size Input and out-ranks the caller's classes, so a consumer matching another field's box has to restate each property with a future: prefix. That breaks silently whenever this block changes.
  • Mirrors InputGroup's existing none variant.

Changes

  • input.tsx: new none variant.
  • input.test.tsx: none carries no future: class, and className replaces its box.
  • input.stories.tsx: none added to the variant control, and a None story with a box drawn by className; it keeps that box under the Future theme.

Demo

Screen.Recording.2026-10-07.at.17.43.58.mov

Testing

  • vitest run for input and input-group (161 passed); the no-future: test fails when the Future block is applied to none.

Jira

MST-16240

Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:10
@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Apollo Coded App preview deployments are ready.

Project Status Preview Updated (PT)
apollo-design Ready Preview · Logs Oct 08, 2026, 12:50:57 AM
apollo-docs Ready Preview · Logs Oct 08, 2026, 12:50:57 AM
apollo-landing Ready Preview · Logs Oct 08, 2026, 12:50:57 AM
apollo-vertex Ready Preview · Logs Oct 08, 2026, 12:50:57 AM

Copilot AI reviewed Oct 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The additive change preserves existing variants, includes focused regression tests, and has no identified blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Adds variant="none" to apollo-wind’s Input, allowing callers to style its box without Future-theme overrides.

Changes:

  • Adds the optional borderless, transparent, shadow-free variant.
  • Adds regression tests for theme isolation and caller styling.
  • Exposes the variant in Storybook controls.
File Description
packages/​apollo-wind/​src/​components/​ui/​input.tsx Adds the none variant and prop documentation.
packages/​apollo-wind/​src/​components/​ui/​input.test.tsx Tests theme isolation and class overrides.
packages/​apollo-wind/​src/​components/​ui/​input.stories.tsx Adds the variant to controls and descriptions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot added the size:S 10-29 changed lines. label Oct 7, 2026
Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:13
@KodudulaAshishUiPath
KodudulaAshishUiPath force-pushed the feat/MST-16240-input-unstyled branch from 1431907 to a8c0dbb Compare October 7, 2026 12:13
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1937 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1708
ISC 88
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.3 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions github-actions Bot added size:M 30-99 changed lines. and removed size:S 10-29 changed lines. labels Oct 7, 2026
@KodudulaAshishUiPath
KodudulaAshishUiPath force-pushed the feat/MST-16240-input-unstyled branch from a8c0dbb to 39a585a Compare October 7, 2026 12:14
@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.02 MB 50.17 MB ±0
@uipath/apollo-react 48.9% — 7.90 MB 30.84 MB ±0
@uipath/apollo-ui-icons — — 2.86 MB 6.97 MB ±0
@uipath/apollo-wind 74.3% — (21 untracked) 678.7 KB 3.98 MB +41 B
@uipath/ap-chat 85.8% — 43.92 MB 56.80 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Copilot AI reviewed Oct 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The additive change preserves existing behavior, includes focused regression coverage, and has no identified blocking issues.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:15
Copilot AI reviewed Oct 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is small and additive, includes focused regression tests, and has no identified blocking issues.

Review effort: Balanced
Findings: None

@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Storybook visual diff

⚠️ Visual changes detected: 8 changed, 2 added (of 450 compared, 440 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Oct 08, 2026, 01:01:53 AM

Copilot AI balanced review requested due to automatic review settings October 8, 2026 07:43
@KodudulaAshishUiPath
KodudulaAshishUiPath force-pushed the feat/MST-16240-input-unstyled branch from 39a585a to 388a31a Compare October 8, 2026 07:43
Copilot AI reviewed Oct 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The additive change preserves existing behavior, includes focused regression tests, and has no identified blocking issues.

0 open findings

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pkg:apollo-wind size:M 30-99 changed lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KodudulaAshishUiPath