Skip to content

Document separate C-API Clippy checks - #8615

Merged
youknowone merged 1 commit into
RustPython:mainfrom
moreal:fix/capi-cargo-config-guard
Sep 1, 2026
Merged

Document separate C-API Clippy checks#8615
youknowone merged 1 commit into
RustPython:mainfrom
moreal:fix/capi-cargo-config-guard

Conversation

@moreal

@moreal moreal commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Document that rustpython-capi must be excluded from workspace-wide Clippy and linted separately from crates/capi so its Cargo config applies.

Summary by CodeRabbit

  • Documentation
    • Added Clippy linting commands to the testing guidance.
    • Documented separate linting steps for the C API and excluded components.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 39549f3f-529e-43af-ab95-e95e24e549af

📥 Commits

Reviewing files that changed from the base of the PR and between 6af309d and 17e05c7.

📒 Files selected for processing (1)
  • AGENTS.md

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

Added workspace-wide and C-API-specific Clippy commands to the Testing section of AGENTS.md.

Changes

Clippy testing guidance

Layer / File(s) Summary
Document Clippy test commands
AGENTS.md		 Adds workspace Clippy coverage with package exclusions and a separate C-API Clippy command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 17e05

This documentation-only change clarifies how the C-API should be linted, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: leehanjeong

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: documenting separate C-API Clippy checks.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the z-ca-2026 Tag to track Contribution Academy 2026 label Aug 30, 2026
@moreal
Document separate C-API Clippy checks
17e05c7 
Assisted-by: Codex:gpt-5.6-sol
@moreal
moreal force-pushed the fix/capi-cargo-config-guard branch from 2e16490 to 17e05c7 Compare August 30, 2026 06:25
@moreal moreal changed the title Prevent misconfigured C-API test builds Document separate C-API Clippy checks Aug 30, 2026
@moreal moreal added the skip:ci Skip running the ci label Aug 30, 2026
@moreal
moreal marked this pull request as ready for review August 30, 2026 06:30
@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Congrats! CodSpeed is installed 🎉

🆕 36 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Open in CodSpeed

@youknowone
youknowone merged commit cc5f76c into RustPython:main Sep 1, 2026
28 of 34 checks passed
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@moreal
Document separate C-API Clippy checks (#8615)
29c622c 
Assisted-by: Codex:gpt-5.6-sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

@moreal moreal

Labels

skip:ci Skip running the ci z-ca-2026 Tag to track Contribution Academy 2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreal @youknowone