Fix staticmethod and classmethod repr error propagation - #8371
Merged
youknowone merged 1 commit intoJul 26, 2026
Merged
Conversation
Assisted-by: Codex:gpt-5.6-sol
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChangesRepresentation error propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Jul 26, 2026
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thank you for working on it 👍 looks good!
youknowone
pushed a commit
that referenced
this pull request
Sep 16, 2026
Assisted-by: Codex:gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repr()implementations ofstaticmethodandclassmethod.staticmethodandclassmethodusedrepr(vm).unwrap()in theirrepr_str()implementations, which turned exceptions raised by the wrapped object's__repr__()into Rust panics.Since
repr_str()already returnsPyResult<String>, this change uses?to propagate the original Python exception unchanged, matching CPython's behavior.Testing
cargo run -- extra_tests/snippets/syntax_class.pyRegression tests were added for both descriptor types.
Before this change, both test cases triggered a Rust panic when the wrapped object's
__repr__()raised an exception.AI assistance
Codex (GPT-5.6 Sol) was used to investigate and implement this change.
I reviewed and validated all AI-assisted work.
Summary by CodeRabbit
Bug Fixes
staticmethodandclassmethodobjects.Tests