Skip to content

Add more error functions to the c-api #8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bschoenmaeckers wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add more error functions to the c-api #8248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae35b0c
Add more error functions to c-api
bschoenmaeckers Jul 10, 2026
498f2c0
Review
bschoenmaeckers Jul 17, 2026
56f90bd
Review
bschoenmaeckers Jul 20, 2026
e6b1123
Add helper for errno functions
bschoenmaeckers Jul 20, 2026
3712567
Fix wasm
bschoenmaeckers Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add more error functions to c-api 
Add windows error functions

Implement unicode error functions

Add errno functions to c-api

Spell

Review

Refactor windows errors

Review
  • Loading branch information
@bschoenmaeckers
bschoenmaeckers committed Jul 22, 2026
commit ae35b0c3e825db8586caed1eb1010e56708d5f37
284 changes: 244 additions & 40 deletions crates/capi/src/pyerrors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,23 @@ use crate::object::define_py_check;
use crate::util::CStrExt;
use crate::{PyObject, pystate::with_vm};
use core::convert::Infallible;
use core::ffi::{c_char, c_int};
use core::ffi::{CStr, c_char, c_int};
use core::ptr::NonNull;
use core::slice;
pub use errno::*;
use rustpython_vm::builtins::{PyBaseException, PyTuple, PyType};
use rustpython_vm::convert::IntoObject;
use rustpython_vm::exceptions::ExceptionZoo;
use rustpython_vm::signal::set_interrupt_ex;
use rustpython_vm::{AsObject, PyObjectRef, PyResult};
use std::process::abort;
pub use unicode::*;
#[cfg(windows)]
pub use windows::*;

mod errno;
mod unicode;
#[cfg(windows)]
mod windows;

macro_rules! define_exception_statics {
($( $(#[$meta:meta])* $export:ident => $exc:ident ),* $(,)?) => {
Expand Down Expand Up @@ -315,55 +325,249 @@ pub unsafe extern "C" fn PyException_SetContext(exc: *mut PyObject, context: *mu
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyUnicodeDecodeError_Create(
encoding: *const c_char,
object: *const c_char,
length: isize,
start: isize,
end: isize,
reason: *const c_char,
) -> *mut PyObject {
pub unsafe extern "C" fn PyException_SetTraceback(exc: *mut PyObject, tb: *mut PyObject) -> c_int {
with_vm(|vm| {
let encoding = unsafe { encoding.try_as_str(vm) }?;
let reason = unsafe { reason.try_as_str(vm) }?;
let length: usize = length
.try_into()
.map_err(|_| vm.new_system_error("length must be non-negative"))?;
let start: usize = start
.try_into()
.map_err(|_| vm.new_system_error("start must be non-negative"))?;
let end: usize = end
.try_into()
.map_err(|_| vm.new_system_error("end must be non-negative"))?;

let bytes = if object.is_null() {
if length != 0 {
return Err(vm.new_system_error(
"PyUnicodeDecodeError_Create called with null object and non-zero length",
));
}
Vec::new()
let exc = unsafe { &*exc }.try_downcast_ref::<PyBaseException>(vm)?;
let traceback = unsafe { tb.as_ref() }.map(|obj| obj.to_owned());
exc.set___traceback__(vm.unwrap_or_none(traceback), vm)
})
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_Clear() {
with_vm(|vm| vm.set_exception(None))
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_ExceptionMatches(exc: *mut PyObject) -> c_int {
with_vm(|vm| {
if let Some(current) = vm.current_exception() {
current
.class()
.as_object()
.is_subclass(unsafe { &*exc }, vm)
} else {
unsafe { slice::from_raw_parts(object.cast::<u8>(), length) }.to_vec()
Ok(false)
}
})
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_BadArgument() -> c_int {
with_vm::<PyResult<Infallible>, ()>(|vm| {
Err(vm.new_type_error("bad argument type for built-in operation"))
});
0
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_BadInternalCall() {
with_vm::<PyResult<Infallible>, _>(|vm| {
Err(vm.new_system_error("bad argument to internal function"))
})
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_CheckSignals() -> c_int {
with_vm(|vm| vm.check_signals())
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_SetInterrupt() {
PyErr_SetInterruptEx(libc::SIGINT);
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_SetInterruptEx(signum: c_int) -> c_int {
let Ok(signum) = signum.try_into() else {
return -1;
};
set_interrupt_ex(signum).map_or(-1, |_| 0)
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn Py_FatalError(message: *const c_char) -> ! {
let message = if message.is_null() {
c"(null)"
} else {
unsafe { CStr::from_ptr(message) }
};
eprintln!("Fatal Python error: {message:?}");
abort()
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_SetNone(exception: *mut PyObject) {
with_vm::<PyResult<Infallible>, _>(|vm| {
let exc_type = unsafe { (&*exception).to_owned() };
let normalized = vm.normalize_exception(exc_type, vm.ctx.none(), vm.ctx.none())?;
Err(normalized)
})
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_NoMemory() -> *mut PyObject {
with_vm::<PyResult<*mut PyObject>, _>(|vm| Err(vm.new_memory_error("")))
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_Fetch(
ptype: *mut *mut PyObject,
pvalue: *mut *mut PyObject,
ptraceback: *mut *mut PyObject,
) {
with_vm(|vm| {
let (ty, value, tb) = vm.take_raised_exception().map_or_else(
|| {
(
core::ptr::null_mut(),
core::ptr::null_mut(),
core::ptr::null_mut(),
)
},
|exc| {
let (ty, value, tb) = vm.split_exception(exc);
let tb = if vm.is_none(&tb) {
core::ptr::null_mut()
} else {
tb.into_raw().as_ptr()
};
(ty.into_raw().as_ptr(), value.into_raw().as_ptr(), tb)
},
);

if let Some(ptype) = NonNull::new(ptype) {
unsafe { ptype.write(ty) };
}
if let Some(pvalue) = NonNull::new(pvalue) {
unsafe { pvalue.write(value) };
}
if let Some(ptraceback) = NonNull::new(ptraceback) {
unsafe { ptraceback.write(tb) };
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_Restore(
exc_type: *mut PyObject,
exc_val: *mut PyObject,
exc_tb: *mut PyObject,
) {
with_vm(|vm| {
let exc_type = NonNull::new(exc_type).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });
let exc_val = NonNull::new(exc_val).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });
let exc_tb = NonNull::new(exc_tb).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });

if let Some(exc_type) = exc_type {
let normalized = vm.normalize_exception(
exc_type,
vm.unwrap_or_none(exc_val),
vm.unwrap_or_none(exc_tb),
)?;
vm.set_exception(Some(normalized));
} else {
vm.set_exception(None);
};

let exc = vm.new_unicode_decode_error_real(
vm.ctx.new_str(encoding),
vm.ctx.new_bytes(bytes),
start,
end,
vm.ctx.new_str(reason),
Ok(())
})
}

#[unsafe(no_mangle)]
pub extern "C" fn PyErr_GetHandledException() -> *mut PyObject {
with_vm(|vm| {
vm.current_exception()
.map(|exc| exc.into_object().into_raw().as_ptr())
.unwrap_or_default()
})
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_SetHandledException(exc: *mut PyObject) {
with_vm(|vm| {
if let Some(exc) = NonNull::new(exc) {
let exception = unsafe { PyObjectRef::from_raw(exc).downcast_unchecked() };
vm.set_exception(Some(exception));
} else {
vm.set_exception(None);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyErr_GetExcInfo(
ptype: *mut *mut PyObject,
pvalue: *mut *mut PyObject,
ptraceback: *mut *mut PyObject,
) {
with_vm(|vm| {
let (ty, value, tb) = vm.current_exception().map_or_else(
|| {
(
core::ptr::null_mut(),
core::ptr::null_mut(),
core::ptr::null_mut(),
)
},
|exc| {
let (ty, value, tb) = vm.split_exception(exc);
let tb = if vm.is_none(&tb) {
core::ptr::null_mut()
} else {
tb.into_raw().as_ptr()
};
(ty.into_raw().as_ptr(), value.into_raw().as_ptr(), tb)
},
);
Ok(exc)

if let Some(ptype) = NonNull::new(ptype) {
unsafe { ptype.write(ty) };
}
if let Some(pvalue) = NonNull::new(pvalue) {
unsafe { pvalue.write(value) };
}
if let Some(ptraceback) = NonNull::new(ptraceback) {
unsafe { ptraceback.write(tb) };
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyException_SetTraceback(exc: *mut PyObject, tb: *mut PyObject) -> c_int {
pub unsafe extern "C" fn PyErr_SetExcInfo(
exc_type: *mut PyObject,
exc_val: *mut PyObject,
exc_tb: *mut PyObject,
) {
with_vm(|vm| {
let _exc_type = NonNull::new(exc_type).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });
let _exc_tb = NonNull::new(exc_tb).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });
let exc_val = NonNull::new(exc_val).map(|ptr| unsafe { PyObjectRef::from_raw(ptr) });
let exc = exc_val
.map(|obj| {
obj.downcast::<PyBaseException>()
.map_err(|_| vm.new_type_error("exception value must be an exception instance"))
})
.transpose()?;
vm.set_exception(exc);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Ok(())
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyException_GetArgs(exc: *mut PyObject) -> *mut PyObject {
with_vm(|vm| {
let exc = unsafe { &*exc }.try_downcast_ref::<PyBaseException>(vm)?;
let traceback = unsafe { tb.as_ref() }.map(|obj| obj.to_owned());
exc.set___traceback__(vm.unwrap_or_none(traceback), vm)
Ok(exc.args())
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyException_SetArgs(exc: *mut PyObject, args: *mut PyObject) {
with_vm(|vm| {
let exc = unsafe { &*exc }.try_downcast_ref::<PyBaseException>(vm)?;
let args = unsafe { &*args }.to_owned();
exc.as_object().set_attr("args", args, vm)
})
}

Expand Down
Loading