Skip to content

Update test/signalinterproctester.py to 3.14.6 - #8173

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:update-test-signalinterproctester
Jun 26, 2026
Merged

Update test/signalinterproctester.py to 3.14.6#8173
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:update-test-signalinterproctester

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Summary by CodeRabbit

  • Chores
    • Updated test assignment rules for the signal area to ensure its related tests are correctly included.
    • Improved consistency in how test files are matched to this module.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

The dependency table in scripts/update_lib/deps.py now includes an explicit signal entry with its associated test files.

Changes

Signal dependency mapping

Layer / File(s) Summary
signal test mapping
scripts/update_lib/deps.py		 DEPENDENCIES adds a signal entry with signalinterproctester.py and test_signal.py as its test list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hopped through deps with a tiny thump,
Added signal to the test-file jump.
Two tests now sit in their proper nest,
A tidy little mapping does the rest. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change of updating signalinterproctester.py to 3.14.6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ShaharNaveh
ShaharNaveh marked this pull request as ready for review June 26, 2026 08:32
@youknowone
youknowone merged commit 83ce1a7 into RustPython:main Jun 26, 2026
18 checks passed
youknowone pushed a commit that referenced this pull request Sep 16, 2026
@ShaharNaveh
Update test/signalinterproctester.py to 3.14.6 (#8173)
9c027d4 
* Update `test/signalinterproctester.py` to 3.14.6

* Add `signalinterproctester.py` as a test dependency of `test_signal.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone