Skip to content

Align more error messages with CPython 3.14.5 #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
May 28, 2026
Merged

Align more error messages with CPython 3.14.5 #7988

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cb2598
Cannot assign to True/False/None
ShaharNaveh May 27, 2026
328b217
cannot use assignment expressions with ...
ShaharNaveh May 27, 2026
dfd48e0
cannot assign to function call/expression
ShaharNaveh May 27, 2026
90ce4df
Fix more
ShaharNaveh May 27, 2026
d456ed9
Clippy
ShaharNaveh May 27, 2026
e6bf997
clippy
ShaharNaveh May 27, 2026
86984a0
Unmark passing tests
ShaharNaveh May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed May 27, 2026
commit e6bf997391cd8d58a8809c2519745804449c9c06
4 changes: 2 additions & 2 deletions crates/compiler/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl CompileError {
end_loc.character_offset = end_loc.character_offset.saturating_add(1);
}

let expr_str = source_file.source_text().slice(&error.location);
let expr_str = source_file.source_text().slice(error.location);

let msg = parser::parse_expression(expr_str).map_or_else(
|_| match expr_str {
Expand Down Expand Up @@ -171,7 +171,7 @@ impl CompileError {
end_loc.character_offset = end_loc.character_offset.saturating_add(1);
}

let target = source_file.source_text().slice(&error.location);
let target = source_file.source_text().slice(error.location);
let msg = format!("cannot use assignment expressions with {target}");
(ParseErrorType::OtherError(msg), loc, end_loc)
}
Expand Down
Loading