-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Assign opcode ids #6637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Assign opcode ids #6637
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5e4f61f
All opcodes have id
ShaharNaveh 2b6b0bd
Fix names
ShaharNaveh 6b96d0e
Fix `frame.rs`
ShaharNaveh 2a6672f
Fix codegen
ShaharNaveh c5eab6a
re add GetYieldFromIter
ShaharNaveh c56c91f
Fix `frame.rs`
ShaharNaveh 04f6d42
Fix `opcode.rs`
ShaharNaveh a7a0eda
Fix `TryFrom<u8>` for `Instruction`
ShaharNaveh 1646643
Mark failing tests
ShaharNaveh e166fda
fix jit
ShaharNaveh 6df35bf
Fix more jit
ShaharNaveh 2ab530e
Merge remote-tracking branch 'upstream/main' into bytecode-opcode-id
ShaharNaveh 04139e4
Merge remote-tracking branch 'upstream/main' into bytecode-opcode-id
ShaharNaveh b222c80
VarArgs -> Varargs
ShaharNaveh 0006700
Refactor scripts/generate_opcode_metadata.py
ShaharNaveh 89c20f6
Add placeholder opcodes
ShaharNaveh 6cdf6f5
Fix
ShaharNaveh 8e1433c
Don't crash on placejolder bytecode
ShaharNaveh 9e6cbed
Unmark passing test
ShaharNaveh 258f61c
Mark failing test
ShaharNaveh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix
- Loading branch information
commit 6cdf6f50e2f29fadccf487d076bb85dcdbd2e411
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 732
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 144
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2516
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 4048
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 8457
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 119
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1542
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 4067
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 68
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 788
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 786
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 66
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 344
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 232
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2554
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1752
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 379
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1286
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 68
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 68
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1280
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1504
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 544
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 2371
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 47
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 67
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 68
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 366
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 4028
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 118
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 69
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 765
Add compile-time exhaustiveness checking for new instruction variants.
The catch-all pattern with
unreachable!()disables Rust's exhaustiveness checking. If newInstructionvariants are added to the enum without corresponding match arms here, they will panic at runtime rather than fail at compile time. Consider restructuring to leverage the compiler's exhaustiveness checking—for example, by removing the catch-all if all variants are already handled, or by using a#[non_exhaustive]attribute on the enum to make missing handlers a compile error.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShaharNaveh uuuuh, this is totally right. I immediately broken build by forgetting change arm during merge. listing all is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.