Skip to content

Commit 33cead3

Browse files
committed
Annotated skips on failing tests
1 parent 43de102 commit 33cead3

5 files changed

Lines changed: 7 additions & 16 deletions

File tree

Lib/test/test_ftplib.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io
99
import errno
1010
import os
11+
import sys
1112
import threading
1213
import time
1314
import unittest
@@ -902,7 +903,7 @@ def retr():
902903
self.client.set_pasv(False)
903904
retr()
904905

905-
906+
@unittest.skip('TODO: RUSTPYTHON; SSL + asyncore has problem; flaky')
906907
@skipUnless(ssl, "SSL not available")
907908
@requires_subprocess()
908909
class TestTLS_FTPClassMixin(TestFTPClass):
@@ -919,18 +920,6 @@ def setUp(self, encoding=DEFAULT_ENCODING):
919920
self.client.auth()
920921
self.client.prot_p()
921922

922-
@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
923-
def test_encoding_param(self):
924-
super().test_encoding_param()
925-
926-
@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
927-
def test_storbinary(self):
928-
super().test_storbinary()
929-
930-
@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
931-
def test_storbinary_rest(self):
932-
super().test_storbinary_rest()
933-
934923
@skipUnless(ssl, "SSL not available")
935924
@requires_subprocess()
936925
class TestTLS_FTPClass(TestCase):

Lib/test/test_importlib/test_threaded_import.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ def target():
249249
__import__(TESTFN)
250250
del sys.modules[TESTFN]
251251

252+
@unittest.skip('TODO: RUSTPYTHON; hang; Suspected cause of crashes in Windows CI - PermissionError: [WinError 32] Permission denied: "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\test_python_0cdrhhs_\\test_python_6340æ"')
252253
def test_concurrent_futures_circular_import(self):
253254
# Regression test for bpo-43515
254255
fn = os.path.join(os.path.dirname(__file__),

Lib/test/test_sqlite3/test_regression.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ def collation_cb(a, b):
266266
# Lone surrogate cannot be encoded to the default encoding (utf8)
267267
"\uDC80", collation_cb)
268268

269+
@unittest.skip("TODO: RUSTPYTHON; deadlock")
269270
def test_recursive_cursor_use(self):
270271
"""
271272
http://bugs.python.org/issue10811
@@ -447,6 +448,7 @@ def test_table_lock_cursor_dealloc(self):
447448
con.execute("drop table t")
448449
con.commit()
449450

451+
@unittest.skip("TODO: RUSTPYTHON; deadlock")
450452
def test_table_lock_cursor_non_readonly_select(self):
451453
with memory_database() as con:
452454
con.execute("create table t(t)")
@@ -474,6 +476,7 @@ def test_executescript_step_through_select(self):
474476
self.assertEqual(steps, values)
475477

476478

479+
@unittest.skip('TODO: RUSTPYTHON deadlock')
477480
class RecursiveUseOfCursors(unittest.TestCase):
478481
# GH-80254: sqlite3 should not segfault for recursive use of cursors.
479482
msg = "Recursive use of cursors not allowed"
@@ -497,7 +500,6 @@ def test_recursive_cursor_init(self):
497500
self.assertRaisesRegex(sqlite.ProgrammingError, self.msg,
498501
self.cur.fetchall)
499502

500-
@unittest.skip("TODO: RUSTPYTHON; Hangs")
501503
def test_recursive_cursor_close(self):
502504
conv = lambda x: self.cur.close()
503505
with patch.dict(sqlite.converters, {"CLOSE": conv}):

Lib/test/test_ssl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4596,7 +4596,7 @@ def server_callback(identity):
45964596
with client_context.wrap_socket(socket.socket()) as s:
45974597
s.connect((HOST, server.port))
45984598

4599-
@unittest.expectedFailure #TODO: RUSTPYTHON
4599+
@unittest.skip('TODO: RUSTPYTHON')
46004600
def test_thread_recv_while_main_thread_sends(self):
46014601
# GH-137583: Locking was added to calls to send() and recv() on SSL
46024602
# socket objects. This seemed fine at the surface level because those

Lib/test/test_zipfile/test_core.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3570,7 +3570,6 @@ def test_cli_with_metadata_encoding(self):
35703570
self.assertIn(name, listing)
35713571

35723572
@unittest.skip('TODO: RUSTPYTHON; shift_jis encoding unsupported')
3573-
@unittest.expectedFailure # TODO: RUSTPYTHON
35743573
def test_cli_with_metadata_encoding_extract(self):
35753574
os.mkdir(TESTFN2)
35763575
self.addCleanup(rmtree, TESTFN2)

0 commit comments

Comments
 (0)