fix(dingtalk): close streaming marker review blockers

qqqys · Aug 14, 2026 · Aug 14, 2026 · Aug 14, 2026 · Aug 15, 2026 · Aug 15, 2026
commit 092ff525f92189aee3c9f5bbdd7d45279b79ccd6
diff --git a/packages/channels/dingtalk/src/interaction-presenter.test.ts b/packages/channels/dingtalk/src/interaction-presenter.test.ts
@@ -790,6 +790,18 @@ describe('DingtalkInteractionPresenter', () => {
     );
   });
 
+  it('reassembles a file marker split across streamed chunks', async () => {
+    const sendFallback = vi.fn().mockResolvedValue(undefined);
+    const presenter = new DingtalkInteractionPresenter({ sendFallback });
+    presenter.registerRun('run-1', 'owner-1', target);
+    presenter.appendOutput(segment('segment-1'), 'A [FILE: /tm');
+    presenter.appendOutput(segment('segment-1'), 'p/x.pdf] B');
+
+    await presenter.closeOutput('segment-1', '', 'response_boundary');
+
+    expect(sendFallback).toHaveBeenCalledWith('cid-1', 'A  B', 'session-1');
+  });
+
   it('neutralizes an image marker orphaned by file sanitization', async () => {
     const sendFallback = vi.fn().mockResolvedValue(undefined);
     const presenter = new DingtalkInteractionPresenter({ sendFallback });

diff --git a/packages/channels/dingtalk/src/interaction-presenter.ts b/packages/channels/dingtalk/src/interaction-presenter.ts
@@ -35,6 +35,7 @@ interface SegmentPresentation {
   run: RunPresentation;
   context: ChannelOutputSegmentContext;
   content: string;
+  displayContent: string;
 }
 
 export interface DingtalkInteractionPresenterOptions {
@@ -135,16 +136,19 @@ export class DingtalkInteractionPresenter {
       run,
       context: segment,
       content: '',
+      displayContent: '',
     };
-    presentation.content = this.boundContent(presentation.content + chunk);
+    const accumulated = presentation.content + chunk;
+    presentation.content = this.boundContent(accumulated);
+    presentation.displayContent = this.boundDisplayContent(accumulated);
     this.segments.set(segment.segmentId, presentation);
     run.activeSegmentId = segment.segmentId;
     const statusContext = this.ensureStatusContext(run, segment);
     void this.enqueue(run, () => {
       this.options.statusCards?.replace(
         statusContext,
         this.cardTarget(statusContext.target),
-        presentation.content,
+        accumulated,
       );
     });
   }
@@ -193,15 +197,17 @@ export class DingtalkInteractionPresenter {
           (await statusCards.flushPending(statusContext.segmentId));
         if (deliveredViaCard) {
           run.cardDelivered = {
-            text: sanitizeFallbackOutput(text || presentation.content),
+            text: text
+              ? this.boundDisplayContent(text)
+              : presentation.displayContent,
             chatId: presentation.context.target.chatId,
             sessionId: presentation.context.sessionId,
           };
           return true;
         }
-        const fallbackText = sanitizeFallbackOutput(
-          text || presentation.content,
-        );
+        const fallbackText = text
+          ? this.boundDisplayContent(text)
+          : presentation.displayContent;
         if (!fallbackText || !this.options.sendFallback) return false;
         await this.options.sendFallback(
           presentation.context.target.chatId,
@@ -215,13 +221,13 @@ export class DingtalkInteractionPresenter {
           statusCards !== undefined &&
           (await statusCards.complete(
             statusContext.segmentId,
-            this.withSenderPrefix(run, text || presentation.content),
+            this.withSenderPrefix(run, text || presentation.displayContent),
           ));
         run.statusContext = undefined;
         if (completed) return true;
-        const fallbackText = sanitizeFallbackOutput(
-          text || presentation.content,
-        );
+        const fallbackText = text
+          ? this.boundDisplayContent(text)
+          : presentation.displayContent;
         if (!fallbackText || !this.options.sendFallback) return false;
         await this.options.sendFallback(
           presentation.context.target.chatId,
@@ -235,10 +241,12 @@ export class DingtalkInteractionPresenter {
         statusCards !== undefined &&
         (await statusCards.complete(
           statusContext.segmentId,
-          this.withSenderPrefix(run, text || presentation.content),
+          this.withSenderPrefix(run, text || presentation.displayContent),
         ));
       if (completed) return true;
-      const fallbackText = sanitizeFallbackOutput(text || presentation.content);
+      const fallbackText = text
+        ? this.boundDisplayContent(text)
+        : presentation.displayContent;
       if (!fallbackText || !this.options.sendFallback) return false;
       await this.options.sendFallback(
         presentation.context.target.chatId,
@@ -395,6 +403,10 @@ export class DingtalkInteractionPresenter {
   }
 
   private boundContent(content: string, limit = CONTENT_LIMIT): string {
+    return truncateOutboundMediaText(content, limit, TRUNCATION_MARKER);
+  }
+
+  private boundDisplayContent(content: string, limit = CONTENT_LIMIT): string {
     return truncateOutboundMediaText(
       sanitizeFallbackOutput(content),
       limit,
@@ -403,15 +415,15 @@ export class DingtalkInteractionPresenter {
   }
 
   private withSenderPrefix(run: RunPresentation, content: string): string {
-    if (!run.senderPrefix) return this.boundContent(content);
+    if (!run.senderPrefix) return this.boundDisplayContent(content);
     const body = this.withoutExistingSenderPrefix(run, content);
     if (!body) return run.senderPrefix;
     const separator = '\n\n';
     const bodyLimit = Math.max(
       0,
       CONTENT_LIMIT - run.senderPrefix.length - separator.length,
     );
-    return `${run.senderPrefix}${separator}${this.boundContent(
+    return `${run.senderPrefix}${separator}${this.boundDisplayContent(
       body,
       bodyLimit,
     )}`;

diff --git a/packages/channels/dingtalk/src/outbound-markers.test.ts b/packages/channels/dingtalk/src/outbound-markers.test.ts
@@ -23,6 +23,12 @@ describe('outbound media markers', () => {
         'FILE',
       )[0]?.path,
     ).toBe('/workspace/report.pdf');
+    expect(
+      findOutboundMediaMarkers(
+        'Chart [IMAGE: /tmp/chart.png] as shown [1].',
+        'IMAGE',
+      )[0]?.path,
+    ).toBe('/tmp/chart.png');
   });
 
   it('walks past index zero and strips the earliest partial marker', () => {
@@ -36,6 +42,13 @@ describe('outbound media markers', () => {
         '[File pending]',
       ),
     ).toBe('see [File pending]');
+    expect(
+      stripPartialOutboundMediaMarker(
+        'see [IMAGE: /Users/ben/private/a [FILE: /tmp/b]',
+        'IMAGE',
+        '[Image pending]',
+      ),
+    ).toBe('see [Image pending]');
   });
 
   it('keeps truncation boundaries outside partial markers', () => {
@@ -51,5 +64,12 @@ describe('outbound media markers', () => {
     expect(
       truncateOutboundMediaText(`[${'a'.repeat(200)}`, 100, truncationMarker),
     ).toHaveLength(100);
+    expect(
+      truncateOutboundMediaText(
+        `${'a'.repeat(114)}[${'b'.repeat(53)}`,
+        80,
+        truncationMarker,
+      ),
+    ).toHaveLength(80);
   });
 });
diff --git a/packages/channels/dingtalk/src/outbound-markers.ts b/packages/channels/dingtalk/src/outbound-markers.ts
@@ -85,33 +85,75 @@ function maskCode(text: string): string {
   return masked.join('');
 }
 
-const MEDIA_MARKER_PREFIXES = ['IMAGE:', 'FILE:'];
+const MEDIA_MARKER_PATTERN = /\[(IMAGE|FILE):\s*/giu;
 
 function previousOpenBracket(text: string, open: number): number {
   return open === 0 ? -1 : text.lastIndexOf('[', open - 1);
 }
 
+function isMarkerCloseBoundary(
+  text: string,
+  close: number,
+  boundary: number,
+): boolean {
+  let cursor = close + 1;
+  if (cursor >= boundary || /\s/u.test(text[cursor]!)) return true;
+  while (
+    cursor < boundary &&
+    /[.,;:!?)}\]，。；：！？）】]/u.test(text[cursor]!)
+  ) {
+    cursor++;
+  }
+  return (
+    cursor > close + 1 && (cursor >= boundary || /\s/u.test(text[cursor]!))
+  );
+}
+
+function findMarkerClose(
+  text: string,
+  pathStart: number,
+  boundary: number,
+): number {
+  let close = text.indexOf(']', pathStart);
+  let lastClose = -1;
+  while (close !== -1 && close < boundary) {
+    lastClose = close;
+    if (isMarkerCloseBoundary(text, close, boundary)) return close;
+    close = text.indexOf(']', close + 1);
+  }
+  return lastClose;
+}
+
+function markerBoundary(
+  visibleText: string,
+  pathStart: number,
+  nextOpening: number | undefined,
+): number {
+  let boundary = nextOpening ?? visibleText.length;
+  const lineBreak = visibleText.slice(pathStart, boundary).search(/[\r\n]/u);
+  if (lineBreak !== -1) boundary = pathStart + lineBreak;
+  return boundary;
+}
+
 function markerSafeTruncationStart(text: string, start: number): number {
-  const before = text.slice(0, start);
-  const lastClose = before.lastIndexOf(']');
+  const visibleText = maskCode(text);
+  const before = visibleText.slice(0, start);
   let open = before.lastIndexOf('[');
-  while (open > lastClose) {
-    const candidate = before.slice(open + 1);
-    if (!/[\r\n]/u.test(candidate)) {
-      const normalized = candidate.toUpperCase();
-      if (
-        MEDIA_MARKER_PREFIXES.some(
-          (prefix) =>
-            prefix.startsWith(normalized) || normalized.startsWith(prefix),
-        )
-      ) {
-        const close = text.indexOf(']', start);
-        const newline = text
-          .slice(start, close === -1 ? undefined : close)
-          .search(/[\r\n]/u);
-        if (close === -1 || newline !== -1) return text.length;
-        return close + 1;
-      }
+  while (open !== -1) {
+    const opening = visibleText.slice(open).match(/^\[(IMAGE|FILE):\s*/iu);
+    if (opening) {
+      const pathStart = open + opening[0].length;
+      const nextOpeningOffset = visibleText
+        .slice(pathStart)
+        .search(MEDIA_MARKER_PATTERN);
+      const boundary = markerBoundary(
+        visibleText,
+        pathStart,
+        nextOpeningOffset === -1 ? undefined : pathStart + nextOpeningOffset,
+      );
+      const close = findMarkerClose(visibleText, pathStart, boundary);
+      if (close >= start) return close + 1;
+      if (close === -1 && boundary >= start) return boundary;
     }
     open = previousOpenBracket(before, open);
   }
@@ -140,8 +182,7 @@ export function findOutboundMediaMarkers(
   markerName: 'IMAGE' | 'FILE',
 ): OutboundMediaMarker[] {
   const visibleText = maskCode(text);
-  const markerPattern = /\[(IMAGE|FILE):\s*/giu;
-  const openings = [...visibleText.matchAll(markerPattern)];
+  const openings = [...visibleText.matchAll(MEDIA_MARKER_PATTERN)];
   const markers: OutboundMediaMarker[] = [];
 
   for (let i = 0; i < openings.length; i++) {
@@ -150,11 +191,13 @@ export function findOutboundMediaMarkers(
       continue;
     }
     const pathStart = match.index + match[0].length;
-    let boundary = openings[i + 1]?.index ?? visibleText.length;
-    const lineBreak = visibleText.slice(pathStart, boundary).search(/[\r\n]/u);
-    if (lineBreak !== -1) boundary = pathStart + lineBreak;
-    const close = visibleText.lastIndexOf(']', boundary - 1);
-    if (close < pathStart) continue;
+    const boundary = markerBoundary(
+      visibleText,
+      pathStart,
+      openings[i + 1]?.index,
+    );
+    const close = findMarkerClose(visibleText, pathStart, boundary);
+    if (close === -1) continue;
     const path = text.slice(pathStart, close).trim();
     if (!path) continue;
     markers.push({
@@ -199,7 +242,10 @@ export function stripPartialOutboundMediaMarker(
   while (open !== -1) {
     const candidate = visibleText.slice(open + 1);
     if (/[\r\n]/u.test(candidate)) break;
-    if (candidate.includes(']')) {
+    const nextOpen = visibleText.indexOf('[', open + 1);
+    const ownSegment =
+      nextOpen === -1 ? candidate : candidate.slice(0, nextOpen - open - 1);
+    if (ownSegment.includes(']')) {
       open = previousOpenBracket(visibleText, open);
       continue;
     }

diff --git a/packages/channels/dingtalk/src/status-card-controller.ts b/packages/channels/dingtalk/src/status-card-controller.ts
@@ -53,6 +53,10 @@ export interface StatusCardControllerOptions {
 }
 
 function boundContent(content: string): string {
+  return truncateOutboundMediaText(content, CONTENT_LIMIT, TRUNCATION_MARKER);
+}
+
+function boundDisplayContent(content: string): string {
   return truncateOutboundMediaText(
     sanitizeStreamingMediaMarkers(content),
     CONTENT_LIMIT,
@@ -96,7 +100,7 @@ export class StatusCardController {
     if (record.terminal) return;
     record.content = boundContent(content);
     if (record.streamFailed) return;
-    record.pendingSnapshot = sanitizeStreamingMediaMarkers(record.content);
+    record.pendingSnapshot = boundDisplayContent(content);
     this.scheduleFlush(record);
   }
 
@@ -140,6 +144,7 @@ export class StatusCardController {
     initialContent = '',
   ): StatusRecord {
     const outTrackId = `qwen-status-${randomUUID()}`;
+    const initialSnapshot = boundDisplayContent(initialContent);
     const record: StatusRecord = {
       segmentId: segment.segmentId,
       runId: segment.runId,
@@ -165,7 +170,7 @@ export class StatusCardController {
       this.segmentIdsByRun.get(record.runId) ?? new Set<string>();
     segmentIds.add(record.segmentId);
     this.segmentIdsByRun.set(record.runId, segmentIds);
-    record.ready = this.create(record, target);
+    record.ready = this.create(record, target, initialSnapshot);
     void record.ready.then((ready) => {
       if (ready) this.scheduleStatusRefresh(record);
     });
@@ -177,17 +182,11 @@ export class StatusCardController {
     text: string,
     retainedContent?: (content: string) => string,
   ): Promise<boolean> {
-    return this.finalize(
-      segmentId,
-      boundContent(text),
-      'Completed',
-      false,
-      retainedContent,
-    );
+    return this.finalize(segmentId, text, 'Completed', false, retainedContent);
   }
 
   fail(segmentId: string, error: string): void {
-    void this.finalize(segmentId, boundContent(error), 'Failed', true);
+    void this.finalize(segmentId, error, 'Failed', true);
   }
 
   cancelRun(runId: string, reason: ChannelTaskCancellationReason): void {
@@ -241,9 +240,9 @@ export class StatusCardController {
   private async create(
     record: StatusRecord,
     target: { chatId: string; isGroup: boolean },
+    initialContent: string,
   ): Promise<boolean> {
     try {
-      const initialContent = sanitizeStreamingMediaMarkers(record.content);
       await this.options.client.createAndDeliver({
         templateId: STATUS_CARD_TEMPLATE_ID,
         outTrackId: record.outTrackId,
@@ -360,9 +359,7 @@ export class StatusCardController {
       const retained =
         content ||
         (retainedContent ? retainedContent(record.content) : record.content);
-      const finalContent = boundContent(
-        sanitizeStreamingMediaMarkers(retained),
-      );
+      const finalContent = boundDisplayContent(retained);
       await this.options.client.openOrUpdateStream({
         outTrackId: record.outTrackId,
         key: 'content',