fix(workflows): restrict pause to background runs

wenshao · Aug 8, 2026 · Aug 1, 2026 · Aug 1, 2026 · Aug 1, 2026 · Aug 1, 2026
commit b84c14492edac304d0a5dfd55486d4c2cdc1eba0
diff --git a/packages/cli/src/ui/components/background-view/BackgroundTasksDialog.test.tsx b/packages/cli/src/ui/components/background-view/BackgroundTasksDialog.test.tsx
@@ -691,6 +691,19 @@ describe('BackgroundTasksDialog', () => {
     expect(h.workflowResume).not.toHaveBeenCalled();
   });
 
+  it('does not offer or trigger pause for a foreground workflow', () => {
+    const h = setup([
+      workflowEntry({ status: 'running', isBackgrounded: false }),
+    ]);
+
+    h.call(() => h.probe.current!.actions.openDialog());
+    expect(h.lastFrame()).not.toContain('p pause');
+    h.pressKey({ sequence: 'p' });
+
+    expect(h.workflowPause).not.toHaveBeenCalled();
+    expect(h.workflowResume).not.toHaveBeenCalled();
+  });
+
   it.each([
     ['running', 'pause'],
     ['paused', 'resume'],
@@ -1006,6 +1019,7 @@ describe('BackgroundTasksDialog', () => {
       perPhaseTokens: new Map<string | null, number>(),
       pendingApprovals: [] as WorkflowApproval[],
       script: '',
+      isBackgrounded: true,
     };
     return { ...base, ...overrides } as unknown as DialogEntry;
   }

diff --git a/packages/cli/src/ui/components/background-view/BackgroundTasksDialog.tsx b/packages/cli/src/ui/components/background-view/BackgroundTasksDialog.tsx
@@ -189,7 +189,7 @@ function isStoppableEntry(entry: DialogEntry): boolean {
 }
 
 function workflowPauseHint(entry: DialogEntry | null): string | undefined {
-  if (entry?.kind !== 'workflow') return undefined;
+  if (entry?.kind !== 'workflow' || !entry.isBackgrounded) return undefined;
   switch (entry.status) {
     case 'running':
       return 'p pause (cooperative)';

diff --git a/packages/cli/src/ui/contexts/BackgroundTaskViewContext.tsx b/packages/cli/src/ui/contexts/BackgroundTaskViewContext.tsx
@@ -298,7 +298,7 @@ export function BackgroundTaskViewProvider({
   const toggleSelectedWorkflowPause = useCallback(() => {
     if (!config) return;
     const target = entries[selectedIndex];
-    if (!target || target.kind !== 'workflow') return;
+    if (!target || target.kind !== 'workflow' || !target.isBackgrounded) return;
     const registry = config.getWorkflowRunRegistry();
     if (target.status === 'running') {
       registry.pause(target.runId);

@@ -770,7 +770,7 @@ describe('WorkflowRunRegistry', () => {
 
   it('does not resume a workflow until pausing has reached paused', () => {
     const r = new WorkflowRunRegistry();
-    const entry = r.register(reg('wf_resume_gate'));
+    const entry = r.register(reg('wf_resume_gate', { isBackgrounded: true }));
     const handle = {
       runId: entry.runId,
       abort: vi.fn(),
@@ -790,6 +790,21 @@ describe('WorkflowRunRegistry', () => {
     expect(handle.resume).toHaveBeenCalledOnce();
   });
 
+  it('does not pause a foreground workflow', () => {
+    const r = new WorkflowRunRegistry();
+    const entry = r.register(reg('wf_foreground'));
+    const handle = {
+      runId: entry.runId,
+      abort: vi.fn(),
+      pause: vi.fn(() => true),
+      resume: vi.fn(() => true),
+    } as unknown as WorkflowRunHandle;
+    r.attachHandle(handle);
+
+    expect(r.pause(entry.runId)).toBe(false);
+    expect(handle.pause).not.toHaveBeenCalled();
+  });
+
   it('setRecentLogs caps at 100 entries (keeps the tail)', () => {
     const r = new WorkflowRunRegistry();
     r.register(reg('wf_1'));

@@ -446,7 +446,9 @@ export class WorkflowRunRegistry {
   pause(runId: string): boolean {
     const entry = this.entries.get(runId);
     const handle = this.handles.get(runId);
-    if (!entry || entry.status !== 'running' || !handle) return false;
+    if (!entry?.isBackgrounded || entry.status !== 'running' || !handle) {
+      return false;
+    }
     return handle.pause();
   }