Skip to content

feat(loop): add second-resolution session wakeup engine #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 9 commits into from
Jun 18, 2026
Merged

feat(loop): add second-resolution session wakeup engine #5182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f3ceec1
feat(loop): add second-resolution session wakeup engine
qqqys Jun 16, 2026
0abcdaa
fix(loop): tighten session wakeup lifecycle
qqqys Jun 16, 2026
23a0882
fix(loop): address wakeup review nits
qqqys Jun 16, 2026
dbcf0aa
fix(loop): clarify wakeup delay reporting
qqqys Jun 16, 2026
8dd6268
fix(loop): expose wakeups through cron management
qqqys Jun 16, 2026
f9fb3e6
fix(loop): align wakeup delay reporting
qqqys Jun 17, 2026
3f16b58
merge upstream main into loop wakeup PR
qqqys Jun 18, 2026
3780b69
test(loop): remove duplicate wakeup cron tests
qqqys Jun 18, 2026
af586cb
fix(loop): include wakeups in scheduler size
qqqys Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(loop): include wakeups in scheduler size
  • Loading branch information
@qqqys
qqqys committed Jun 18, 2026
commit af586cb6938bb26aed82d59f0475e7903f042c9b
6 changes: 3 additions & 3 deletions packages/core/src/services/cronScheduler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ describe('CronScheduler', () => {
expect(scheduler.sessionSize).toBe(0);
});

it('lists wakeups without counting them against the cron job limit', () => {
it('lists wakeups as active scheduler work', () => {
scheduler.scheduleWakeup(300, 'p');
expect(scheduler.list()).toMatchObject([
{
Expand All @@ -604,7 +604,7 @@ describe('CronScheduler', () => {
jitterMs: 0,
},
]);
expect(scheduler.size).toBe(0);
expect(scheduler.size).toBe(1);
});

it('does not count wakeups against the cron job limit', () => {
Expand All @@ -613,7 +613,7 @@ describe('CronScheduler', () => {
}

expect(() => scheduler.scheduleWakeup(300, 'wake up')).not.toThrow();
expect(scheduler.size).toBe(50);
expect(scheduler.size).toBe(51);
expect(scheduler.sessionSize).toBe(51);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/services/cronScheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,10 +425,10 @@ export class CronScheduler {
}

/**
* Returns the number of active jobs.
* Returns the number of active jobs and wakeups.
*/
get size(): number {
return this.jobs.size;
return this.jobs.size + this.wakeups.size;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tools/loop-wakeup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('LoopWakeupTool', () => {
cronExpr: '@wakeup',
prompt: 'continue loop',
});
expect(scheduler.size).toBe(0);
expect(scheduler.size).toBe(1);
});

it('rejects scheduling when the scheduler is disabled', async () => {
Expand Down
Loading