Repository navigation
fix(installer): auto-detect SYSTEM account and default PATH scope to machine - #4903
Merged
Merged
Conversation
yiliang114
added
priority/P2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows standalone installer to default PATH persistence to Machine scope when running under the SYSTEM account, and introduces explicit controls to repair or choose PATH scope so qwen remains discoverable in new service-spawned sessions (SSM/WinRM/scheduled tasks).
Changes:
- Auto-detect SYSTEM (SID
S-1-5-18) ininstall-qwen-standalone.batand default PATH scope tomachine, plus new--repair-pathand--path-scope user|machineoptions (and env vars). - Uninstaller now removes both User and Machine PATH entries for the standalone shim directory.
- Adds CI/test/docs updates to validate hosted-asset packaging preserves the new flags.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/tests/install-script.test.js |
Extends workflow assertions to require hosted-asset validation and presence of new installer flags. |
scripts/installation/uninstall-qwen-standalone.ps1 |
Removes standalone bin dir from both User and Machine PATH and updates current-session PATH accordingly. |
scripts/installation/INSTALLATION_GUIDE.md |
Documents --repair-path, --path-scope, and related environment variables. |
scripts/installation/install-qwen-standalone.bat |
Adds SYSTEM detection for PATH scope defaulting, new CLI/env options, and PATH repair mode. |
scripts/build-hosted-installation-assets.js |
Adds hosted-installer behavior checks for new flags (needs tighter regex to avoid false positives). |
.github/workflows/sync-release-to-oss.yml |
Adds a stable-release validation step checking hosted .bat contains the new flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
Author
|
@qwen-code /triage |
Collaborator
Local runtime verification reportSince the risky part of this PR is batch arg parsing + scope selection + real registry writes, I ran the changed installer end-to-end against a real Scenario matrix
Evidence: registry before/after for scenarios 7, 8, 11S7/S8 (machine scope; S8 via SYSTEM auto-detect, no flags): S11 (uninstall, both scopes seeded): Repo checks
Observations (non-blocking)
Not covered here
Verdict: every executable scenario matches the PR description, including the headline SSM/SYSTEM auto-detect behavior and the dual-scope uninstall cleanup; no regressions found. LGTM from the runtime side. |
Collaborator
|
Heads-up: #4915 just merged a fix for the same two |
…machine When the Windows standalone installer runs as the SYSTEM account (SID S-1-5-18), which is common for ECS Workbench SSM, WinRM, and scheduled tasks, the default --path-scope is now 'machine' instead of 'user'. Previously, persisting PATH to the SYSTEM user's HKCU hive had no effect on new sessions spawned by the SSM agent service, because the agent inherits its environment at service start time and never re-reads HKCU. Writing to the Machine PATH (HKLM) ensures new sessions pick up the qwen shim immediately. Also adds: - --repair-path flag to fix PATH for an existing install without reinstalling - --path-scope user|machine CLI option and QWEN_INSTALL_PATH_SCOPE env var - Uninstaller now cleans both User and Machine PATH entries - CI validation step for hosted installation assets Resolves #4901
…st fixtures - Remove windows-self-hosted-qwen-smoke.yml (operational tool, not part of fix) - Revert sync-release-to-oss.yml validate step (redundant with JS behavior guards) - Extract duplicated test fixture strings into shared constants - Pass normalized path to Remove-PathEntry to avoid double Get-NormalizedPath - Fix stale comment referencing "user PATH" when scope is now configurable
yiliang114
force-pushed
the
fix/windows-installer-system-path-scope
branch
from
June 10, 2026 02:42
f878072 to
9bd2bf1
Compare
wenshao
approved these changes
Jun 10, 2026
DragonnZhang
approved these changes
Jun 10, 2026
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! The SYSTEM account auto-detection via SID S-1-5-18 is the canonical approach, input validation correctly includes the new env vars, and the uninstall script properly cleans both scopes with graceful error handling. Existing Suggestion-level comments from @qwen-code-ci-bot cover the minor issues (duplicate PATH entry, misleading repair message). -- qwen-code-review via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When the Windows standalone installer runs under the SYSTEM account (SID
S-1-5-18),PATH_SCOPEnow defaults tomachineinstead ofuser. This ensures theqwenshim is written to Machine PATH (HKLM) and discoverable in new terminal sessions spawned by service processes (SSM agent, WinRM, scheduled tasks). Also adds--repair-pathand--path-scope user|machineoptions so users can fix PATH for an existing install without re-downloading, and the uninstaller now cleans both User and Machine PATH entries.Why it's needed
When installing via ECS Workbench (SSM, runs as SYSTEM), the installer persists PATH to the SYSTEM user's HKCU registry hive. New SSM sessions are spawned by the SSM agent service, which loaded its environment at service start time and never re-reads HKCU — so the updated User PATH is never inherited. The result:
qwenworks in the install session but every subsequent session getsCommandNotFoundException. Writing to Machine PATH (HKLM) fixes this because Machine PATH is resolved from the registry at process creation time, regardless of how the session is spawned.Reviewer Test Plan
How to verify
irm https://qwen-code-assets.oss-cn-hangzhou.aliyuncs.com/installation/install-qwen-standalone.ps1 | iexqwen --versionworks in the current sessionqwen --version— should output0.17.1(previously:CommandNotFoundException)--repair-path: runinstall-qwen-standalone.bat --repair-path --path-scope machineon an existing install — should report "PATH repaired" without downloading$env:QWEN_INSTALL_PATH_SCOPE = 'user'; irm ... | iexshould persist to User PATH as beforeEvidence (Before & After)
Before (new SSM session after install):
After (new SSM session after install with this fix):
Tested on
Environment (optional)
ECS Workbench SSM connection (免密连接) to Windows Server instance (us-east-1), running as SYSTEM account (
C:\Windows\system32\config\systemprofile).Risk & Scope
userscope. If the machine has multiple users, the qwen bin dir will appear in all users' PATH — acceptable since standalone installs are typically single-purpose servers..ps1wrapper'sUpdate-CurrentSessionPathstill only patches the current process — it does not callSetEnvironmentVariableitself (that remains the.bat's responsibility).install-qwen-standalone.bat --repair-path --path-scope machineto fix without reinstalling.Linked Issues
Resolves #4901
中文说明
这个 PR 做了什么
当 Windows standalone 安装器检测到运行在 SYSTEM 账户下（SID
S-1-5-18）时，PATH_SCOPE默认改为machine而非user。这确保qwenshim 写入 Machine PATH (HKLM)，新的 SSM/WinRM/计划任务 session 能正确发现qwen命令。同时新增--repair-path和--path-scope user|machine选项，方便用户修复已有安装的 PATH 而无需重新下载。卸载脚本现在同时清理 User 和 Machine 两级 PATH。为什么需要
通过 ECS Workbench SSM 安装时（以 SYSTEM 运行），安装器将 PATH 写入 SYSTEM 用户的 HKCU 注册表。但新的 SSM session 由 SSM agent 服务进程派生，该服务在启动时加载环境变量后不会重新读取 HKCU——因此更新后的 User PATH 永远不会被新 session 继承。表现为：安装 session 中
qwen可用，但每个新 session 报CommandNotFoundException。写入 Machine PATH (HKLM) 可修复此问题，因为 Machine PATH 在进程创建时总是从注册表读取。Reviewer 测试计划
如何验证
irm https://qwen-code-assets.oss-cn-hangzhou.aliyuncs.com/installation/install-qwen-standalone.ps1 | iexqwen --version正常qwen --version— 应输出0.17.1（之前：CommandNotFoundException）--repair-path：对已有安装执行install-qwen-standalone.bat --repair-path --path-scope machine，应显示 "PATH repaired" 且不下载$env:QWEN_INSTALL_PATH_SCOPE = 'user'; irm ... | iex应写入 User PATH证据（修复前后对比）
修复前（安装后新开 SSM session）：
CommandNotFoundException修复后（安装后新开 SSM session）：输出
0.17.1测试平台
环境
ECS Workbench SSM（免密连接），Windows Server 实例 (us-east-1)，SYSTEM 账户。
风险与范围
userscope。.ps1wrapper 的Update-CurrentSessionPath仍然只修改当前进程内存中的 PATH。install-qwen-standalone.bat --repair-path --path-scope machine修复。关联 Issue
Resolves #4901