Repository navigation
fix(docker): fix build error and enable manual version builds - #1722
Merged
Merged
Conversation
tanzhenxin
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis and
pomelo-nwu
as code owners
February 5, 2026 06:41
Contributor
📋 Review SummaryThis PR addresses a Docker build error where the 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Co-authored-by: Qwen-Coder <[email protected]>
tanzhenxin
force-pushed
the
fix/docker-build-and-workflow
branch
from
February 5, 2026 06:52
93f7a8d to
9abb958
Compare
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
fix(docker): fix build error and enable manual version builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes Docker build error where vscode-ide-companion failed due to incorrect build order, and updates GitHub workflow to support manual version input with automatic 'v' prefix stripping.
Dive Deeper
Dockerfile Fix
The original Dockerfile used
npm run build --workspaceswhich runs builds in parallel. This causedvscode-ide-companionto fail because it depends on@qwen-code/webuitypes that hadn't been generated yet.Changed to use
npm run buildwhich callsscripts/build.js- this builds packages in correct dependency order:Workflow Improvements
Updated
build-and-publish-image.ymlto support:0.9.1orv0.9.1)Reviewer Test Plan
Verify the Dockerfile change builds successfully:
docker build -t qwen-code:test .Test manual workflow trigger:
0.9.1(notv0.9.1)Testing Matrix
Linked issues / bugs
No linked issues
🤖 Generated with Qwen Code