Repository navigation
add hint for installing external source extensions - #1694
Merged
Merged
Conversation
Fixes installation failure for Gemini CLI extensions (e.g., conductor) that only provide gemini-extension.json but not qwen-extension.json. Instead of strict schema validation via isGeminiExtensionConfig(), now automatically attempts conversion whenever gemini-extension.json exists. Fixes: #1621
Shows warning when installing Gemini CLI extensions to set user expectations about potential compatibility differences. - Keeps isGeminiExtensionConfig validation intact (no skipped checks) - Zero UI in core package (warning only in CLI layer via consent.ts) - Uses t() for internationalization - Warning appears in consent prompt before installation Fixes: #1621
LaZzyMan
requested review from
DennisYu07,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
February 3, 2026 06:42
Contributor
📋 Review SummaryThis PR introduces a mechanism to warn users when installing extensions from external sources (Claude, Gemini) that may not work perfectly with Qwen Code. It adds internationalization support for the warning message and tracks the origin source of extensions through the installation process. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Syed-Bipul-Rahman
approved these changes
Feb 3, 2026
Contributor
|
@LaZzyMan Thanks for extending this with Claude support and polishing the i18n implementation! Happy to see this moving forward; appreciate you building on my contribution. 😊 |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…ions add hint for installing external source extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This is a supplement to the PR #1636 @Ojhaharsh .
Testing Matrix