Repository navigation
feat: Remove Smart Edit tool and ClearcutLogger - #1684
Merged
Merged
Conversation
- Remove SmartEditTool and its associated LLM edit fixer utilities - Remove ClearcutLogger and related telemetry infrastructure - Remove useSmartEdit configuration option from settings schema - Add deprecation warning for users with existing useSmartEdit config - Clean up all related tests and mocks The Smart Edit tool was designed to provide flexible matching and LLM-based correction for edit operations. However, current models are now capable of effectively using the standard Edit tool without these optimizations, and the Smart Edit tool lacked comprehensive testing coverage. Co-authored-by: Qwen-Coder <[email protected]>
tanzhenxin
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis and
pomelo-nwu
as code owners
February 1, 2026 06:42
Contributor
📋 Review SummaryThis PR removes the Smart Edit tool and ClearcutLogger telemetry system, reducing approximately 4400 lines of untested code. The changes are clean and well-documented, with proper deprecation warnings for the removed configuration option. The removal simplifies the codebase by eliminating unused and overly complex functionality. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Co-authored-by: Qwen-Coder <[email protected]>
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
…t-tool # Conflicts: # packages/core/index.ts # packages/core/src/index.ts
Mingholy
approved these changes
Feb 5, 2026
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
feat: Remove Smart Edit tool and ClearcutLogger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Based on our observations, current models are now capable of effectively using the standard Edit tool without additional optimizations. Additionally, the Smart Edit tool lacked comprehensive testing coverage.
This PR removes the Smart Edit tool and ClearcutLogger telemetry system, reducing approximately 4,400 lines of insufficiently tested code.
Dive Deeper
What Was Removed
Smart Edit Tool related:
packages/core/src/tools/smart-edit.ts- Smart Edit tool implementation (~966 lines)packages/core/src/tools/smart-edit.test.ts- Test file (~674 lines)packages/core/src/utils/llm-edit-fixer.ts- LLM edit fixer utilities (~164 lines)packages/core/src/utils/llm-edit-fixer.test.ts- Test file (~322 lines)ClearcutLogger related:
packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts- ClearcutLogger implementation (~1123 lines)packages/core/src/telemetry/clearcut-logger/clearcut-logger.test.ts- Test file (~748 lines)packages/core/src/telemetry/clearcut-logger/event-metadata-key.ts- Event metadata key definitions (~119 lines)Configuration cleanup:
useSmartEditconfig option fromsettingsSchema.tsuseSmartEditparameter, property, and getter fromConfigclasspackages/core/src/index.tsgetUseSmartEditmocks from testssmart_edit_enabledfield from telemetry loggingWhy Remove These Features?
Smart Edit Tool: This tool was designed to improve edit operations through flexible matching and LLM-based auto-correction. However, as model capabilities have improved, the standard Edit tool is now sufficient. The Smart Edit tool's multi-layer matching logic (exact → flexible → regex → LLM fix) added unnecessary complexity.
ClearcutLogger: This was an unused telemetry system. The project has already migrated to QwenLogger for telemetry data collection.
Reviewer Test Plan
npm run typecheck- should all passcd packages/core && npx vitest run src/config/config.test.tscd packages/core && npx vitest run src/core/coreToolScheduler.test.tscd packages/core && npx vitest run src/telemetry/loggers.test.tsTesting Matrix
Type checking and core tests verified on macOS
Linked issues / bugs
No linked issues
🤖 Generated with Qwen Code