Repository navigation
Fix: React/React-DOM version inconsistency in package.json and lockfile - #1659
Merged
Merged
Conversation
Mingholy
requested review from
DennisYu07,
LaZzyMan,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 29, 2026 08:58
Contributor
📋 Review SummaryThis PR addresses version inconsistencies between React and React-DOM dependencies in package.json and package-lock.json that were causing failures during the release-vscode-companion process. The changes synchronize React and React-DOM versions across the codebase and remove problematic dependencies that were causing conflicts. 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo specific critical issues identified in this review. 🟡 HighNo specific high priority issues identified in this review. 🟢 MediumNo specific medium priority issues identified in this review. 🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Ensure converters always produce a tool_result/tool message even when the function response output is empty, matching provider requirements.
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…ion-ci Fix: React/React-DOM version inconsistency in package.json and lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR fixes two independent issues:
npm ls --workspaces --json --depth=0to fail duringscripts/version.js/release-vscode-companion.Fix 1: VSCode companion CI (dependency/version consistency)
Problem
Release/versioning scripts (notably running
npm ls --workspaces --json --depth=0duringscripts/version.js) were failing due to dependency version inconsistencies betweenpackage.jsonandpackage-lock.json.Changes
Fix 2: Emit empty tool results for OpenAI/Anthropic
Problem
Some provider APIs require that every tool call/tool use has a matching tool response/result. Previously, when a function response contained no text/media (e.g.
{ output: '' }from reading an empty file), we could skip emitting the tool response, which can cause provider validation errors / downstream failures.Changes
role: 'tool'message withcontent: ''when the tool result is empty.Reviewer test plan
For Fix 1
package.jsonandpackage-lock.jsonnpm installnode scripts/version.jsnpm ls --workspaces --json --depth=0release-vscode-companionworkflow path that previously failedFor Fix 2
cd packages/core && npx vitest run src/core/openaiContentGenerator/converter.test.tscd packages/core && npx vitest run src/core/anthropicContentGenerator/converter.test.tsTesting Matrix
Linked issues / bugs
npm ls --workspaces --json --depth=0during versioning)