Repository navigation
Fix Claude plugin resource collection to respect marketplace config - #1639
Merged
Merged
Conversation
…rces - Fixed issue where all skills were installed instead of only configured ones - Resource paths now preserve subdirectory names (e.g., skills/xlsx -> skills/xlsx/) - Support default fallback: use all resources from folder if not specified in config - Added comprehensive tests covering explicit config, default behavior, and nested structures
LaZzyMan
requested review from
DennisYu07,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 28, 2026 03:16
Contributor
📋 Review SummaryThis PR fixes a critical bug in the Claude plugin resource collection mechanism where all resources were being collected instead of only those specified in the marketplace configuration. The changes correctly implement resource filtering and preserve directory structures, with comprehensive tests added to validate the behavior. 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo critical issues identified in this review. 🟡 HighNo high priority issues identified in this review. 🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
Fix Claude plugin resource collection to respect marketplace config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixed a bug where Claude plugin installation would collect all resources from the source directory instead of only those specified in the marketplace configuration.
Dive Deeper
Problem
When installing a Claude plugin (e.g.,
anthropics/skills:document-skills), the converter was:Root Cause
In
collectResources, when copying a directory like./skills/xlsx, files were being flattened directly intotmpDir/skills/instead of preserving the subdirectory structure astmpDir/skills/xlsx/.Solution
./skills/xlsx, maintain it asskills/xlsx/Reviewer Test Plan
Install a plugin with partial resource specification:
Verify only the 4 configured skills (xlsx, docx, pptx, pdf) are installed, not all skills in the folder.
Run the new unit tests:
All 10 tests should pass, including 3 new tests covering explicit config, default behavior, and nested structures.
Testing Matrix