Repository navigation
Support model selection through ACP in vscode ide companion - #1582
Merged
Merged
Conversation
…P session management Co-authored-by: Qwen-Coder <[email protected]>
…vscode-ide-companion-set-model
yiliang114
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 22, 2026 16:49
Contributor
📋 Review SummaryThis PR introduces model selection functionality to the VSCode IDE Companion, allowing users to dynamically switch AI models within their session. The implementation includes new UI components, session management features, and comprehensive test coverage. Overall, the changes are well-structured and significantly enhance the user experience. 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo specific critical issues identified in this review. 🟡 HighNo specific high priority issues identified in this review. 🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
…set-model Support model selection through ACP in vscode ide companion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR adds model selection functionality to the VSCode IDE Companion, enabling dynamic switching of AI models within the IDE. By introducing the ACP session/set_model method and corresponding UI components, users can switch models without interrupting their session. It also includes ACP session management features and tests to enhance system stability and user experience.
Detailed Changes
New Features
Model Selection Feature:
session_set_modelmethod definition inacpSchema.tssetModelmethod inAcpConnectionclass to send model switching requests to ACPModelSelector.tsxcomponent providing a UI for selecting modelsEnhanced ACP Session Management:
AcpSessionManagerclass to manage ACP session statesacpSessionManager.test.tstest file to ensure reliability of session managementQwenAgentManagerto handle model change eventsModel State Handling:
acpTypes.tstype definitions withCurrentModelUpdateandAvailableCommandsUpdateinterfacesqwenSessionUpdateHandler.tsextractSessionModelStateutility function to extract model state from ACP session responsesUI Update Mechanism:
onModelChanged,onAvailableCommands, andonAvailableModelscallback registration methodsFile Changes Detail
New Files:
acpSessionManager.test.ts- Unit tests for ACP session managerqwenSessionUpdateHandler.test.ts- Unit tests for session update handlerModelSelector.tsx- Model selector UI componentStatusIcons.tsx- Status icon componentsacpModelInfo.tsutility functionsModified Files:
acpSchema.ts- Addedsession_set_modelmethodacpConnection.ts- AddedsetModelmethodacpSessionManager.ts- Implemented session management functionalityqwenAgentManager.ts- Integrated model selection featureqwenConnectionHandler.ts- Updated connection handling logicqwenSessionUpdateHandler.ts- Added model update handlingacpTypes.ts- Extended type definitionsApp.tsx- Integrated model selection UIInputForm.tsx- Updated input form UIuseWebViewMessages.ts- Updated Webview message handlingTest Coverage
Reviewer Test Plan
Model Switching Functionality Test:
Session Management Test:
Exception Handling Test:
UI Component Test:
Testing Matrix
Related Issues/Bugs
This PR enhances the VSCode IDE Companion functionality by implementing dynamic model switching capability, providing users with a more flexible development experience.