Repository navigation
feat: clarify output formats for non-interactive mode - #1579
Merged
Merged
Conversation
Contributor
📋 Review SummaryThis PR clarifies the three output formats in non-interactive mode (json, stream-json, text) by unifying JSON and TEXT modes to use the same JsonOutputAdapter internally. The changes simplify tool output handling and remove redundant streaming text output handlers for TEXT mode. Overall, the changes improve the clarity and consistency of output format behavior. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
LaZzyMan
marked this pull request as ready for review
January 26, 2026 05:51
LaZzyMan
requested review from
DennisYu07,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
January 26, 2026 05:51
Mingholy
previously requested changes
Jan 26, 2026
| usage, | ||
| stats, | ||
| summary: message, | ||
| showResult: config.getOutputFormat() === OutputFormat.TEXT, |
Collaborator
There was a problem hiding this comment.
If showResult depends only on --output-format it can be derived by adapter.config.getOutputFormat() so no extra option properties is needed here.
| // Emit the entire messages array as JSON (includes all main agent + subagent messages) | ||
| const json = JSON.stringify(this.messages); | ||
| process.stdout.write(`${json}\n`); | ||
| } |
Collaborator
There was a problem hiding this comment.
We can route JSON and Text both to JSON output (which you have already done) and skip all non-result messages depending on this.config.getOutputFormat(), so that the implementation gap between JSON and Text lays here and here only.
Mingholy
reviewed
Jan 26, 2026
| outputFormat === OutputFormat.JSON || | ||
| outputFormat === OutputFormat.TEXT | ||
| ) { | ||
| adapter = new JsonOutputAdapter(config); |
Collaborator
There was a problem hiding this comment.
Note that there are serveral cases where behaviours depends on the existence of adapter.
Please check and ensure the existence of adapter when output format is text makes no funtional regression.
Collaborator
Author
There was a problem hiding this comment.
Okay, since the change eliminates the case where the adapter doesn't exist, I've removed some redundant checks and handling of the adapter's non-existence (the original text mode).
tanzhenxin
approved these changes
Jan 29, 2026
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
xaelistic
pushed a commit
to xaelistic/qwen-code
that referenced
this pull request
Jun 7, 2026
feat: clarify output formats for non-interactive mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Clarify the three output formats in non-interactive mode: json (non-streaming structured output), stream-json (streaming structured output), and text (non-streaming final result only, similar to Claude Code).
Dive Deeper
Output Format Behavior
Implementation Details
showResultflagReviewer Test Plan
Run non-interactive mode with different output formats:
Verify:
Testing Matrix
Linked issues / bugs
N/A