Repository navigation
Conversation
Update test to match new tool output format that includes tool displayName and description in text mode.
338391f to
6cb4371
Compare
📋 Review SummaryThis PR updates a test case to match the new tool output format in text mode. The nonInteractive mode now outputs tool displayName and description before tool execution output, and the test has been updated to reflect this new behavior. The changes are well-scoped and address the intended functionality correctly. 🔍 General Feedback
🎯 Specific FeedbackNo specific issues identified in this review. The changes are focused on updating the test expectations to match the new tool output format, which is correctly implemented. ✅ Highlights
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
Would it be possible to release this feature as soon as possible? I’d really appreciate your support |
tanzhenxin
left a comment
There was a problem hiding this comment.
Did a quick code review task with this change, and I noticed a few potential issues worth calling out:
- Shell output rendering: The tool results are currently being displayed as
[object Object]instead of the actual command output. - Missing tool displays: Some follow-up tool invocations (e.g. reading the rest of the diff, searching for related test files) appear to run but produce no visible output at all.
|
P.S. I have |
|
This feature will be very useful in CI environments, where clear and structured tool output is essential for debugging and logging. Hope it can be released soon |
|
this pr will be replaced by #1579 |
Add tool displayName and description output for non-Task tools in nonInteractive text mode, and update corresponding test assertions.
Changes: