Repository navigation
Conversation
|
Thanks for the PR — and for digging into why the lane went red instead of just papering over it. The diagnosis in your description is accurate. The problem is that it has since been fixed underneath you. Template looks good ✓ Problem: real when you filed it, no longer real on But #13536 merged at 08:29:34Z — six minutes after you opened this at 08:23:32Z — and its own patch to this same file is the identical Direction: aligned — a gate that any merged commit can break for everyone is worth fixing fast, and fixing it with formatter output rather than by hand is the right instinct. Simply overtaken by events here. Size: not applicable — one docs file, no core paths. Approach: minimal and appropriate for the goal: four lines, formatter output only, no wording changes. Nothing I'd cut. One thing beyond this PR that a maintainer should see: this is a four-way duplicate. #13580 (06:51Z), #13584 (07:27Z) and #13587 (08:01Z) are all still-open Risk: no elevated risk signals — no revert-correlated paths touched. Flagging this before diving deeper, since the substantive finding is that there is nothing left to merge. Code review and CI evidence follow in the next comment. 中文说明感谢贡献——也感谢你查清了 lint lane 变红的原因,而不是简单糊过去。描述里的定位是准确的,只是这个问题已经在背后被修掉了。 模板完整 ✓ 问题: 提交时是真实存在的,但在当前 但 #13536 在 08:29:34Z 合入——比你 08:23:32Z 开这个 PR 晚了六分钟——它对同一个文件的改动是完全相同的 方向: 对齐——任何一个合入的提交都能把全仓门禁搞红,这种事值得快速修;而且用 formatter 输出而不是手改,思路是对的。只是这次被别的合并抢先了。 规模: 不适用——单个文档文件,未触及核心路径。 方案: 对这个目标来说已经是最小改动:四行,纯 formatter 输出,无措辞变更。没有需要砍掉的部分。 有一件超出本 PR、但维护者应该知道的事:这是一个四重复 PR。#13580(06:51Z)、#13584(07:27Z)、#13587(08:01Z)都还开着,都是 风险: 无升级风险信号——未触及与 revert 相关的高风险路径。 先把这个提出来讨论,因为核心结论是:已经没有可合并的内容了。代码审查与 CI 证据见下一条评论。 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Independent proposal first (written before reading the diff): given "a merged docs commit broke the repo-wide Prettier lane", I would run the lockfile-pinned formatter over the offending file and commit exactly its output — nothing more, no hand-tuning, no accompanying cleanup. That is precisely what this PR does, so the approach matches my baseline. The one step I would add is checking whether the fix had already landed on Code review: clean, no blockers, no AGENTS.md violations. The diff is formatter output and nothing else: Prettier's default markdown emphasis normalisation ( One small inconsistency in the description, not a blocker: the summary says "Whitespace and table alignment only, no wording changes", while Risk & Scope correctly discloses that "emphasis-marker style" also moves. The Risk section is the accurate one — emphasis markers are markup, not whitespace. Skipping both optional enrichments (sequence diagram, changed-files table): one file and four lines, so a diagram or a per-file map here would be noise rather than signal. Test evidence — the PR's own CI, read through the API. No PR-derived code was executed. The green lint lane on this PR is vacuous, and that matters because the description leans on it.
Because this PR's own lane cannot substantiate the claim, I went and found CI that does — and it settles both directions:
The Sandboxed lane: none applies, and I want to be explicit about that rather than silently skip it. This is a docs-only change with no runtime surface, so Real-scenario testing: N/A — unattended CI run, and nothing user-visible to drive. 中文说明先写独立方案(在看 diff 之前):面对"一个已合入的文档提交搞红了全仓 Prettier lane",我会用 lockfile 锁定的 formatter 跑一遍出问题的文件,然后原样提交它的输出——不多做别的,不手工微调,不顺手清理。这个 PR 做的正是如此,所以方案与我的基线一致。我唯一会多加的一步,是在开 PR 前先确认修复是否已经进了 代码审查: 干净,无阻塞项,无 AGENTS.md 违规。diff 就是 formatter 输出:Prettier 默认的 markdown 强调符规范化( 描述里有个小的不一致,不构成阻塞:概述写"仅空白与表格对齐,无措辞变更",而 Risk & Scope 正确披露了"强调符样式"也会变。Risk 那段才是准确的——强调符属于 markup,不是空白。 两项可选增强(时序图、变更文件表)都跳过:只有一个文件、四行改动,加图表只会是噪音。 测试证据——通过 API 读取本 PR 自己的 CI,未执行任何 PR 代码。 本 PR 上那个绿色的 lint lane 是空的,而这一点很关键,因为描述里引用了它。 由于本 PR 自己的 lane 无法证实结论,我去找了能证实的 CI,而它把两个方向都讲清了:
描述里贴的 沙箱验证通道:不适用,这里明确说明而不是默默跳过。 这是纯文档改动,没有运行时表面,所以 真实场景测试:N/A——无人值守 CI 运行,且没有用户可见行为可驱动。 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Confidence: 3/5 — the change itself is correct and was well-evidenced when filed, but #13536 landed the identical formatting six minutes later, so there is no delta left to merge and nothing for me to approve. Stepping back: this is a good PR that arrived too late. The diagnosis was right, the fix was the minimal formatter output rather than a hand-edit, the description named the exact pinned version and even flagged the 3.6.1-vs-3.9.9 drift as out of scope instead of quietly widening the diff. Had What stops this from being a clean approve is that approving it would attest to a change that no longer changes anything. So the recommendation is to close this as superseded by #13536. I'm not closing it myself — triage's only automated close path runs through a linked issue that was closed as completed by a merged PR, and this PR deliberately has no linked issue, so that path doesn't apply. @he-yufeng, if you agree, closing it from your side is the cleanest ending; if you think something here is not covered by #13536, say so and I'll re-run. Two things a maintainer should see, neither of them this author's fault:
No approval posted in this run, and no approve-on-green marker — the verdict is defer, not approve. The deterministic maintainer resolver returned nothing here ( 中文说明Confidence: 3/5 — 改动本身是正确的,提交时证据也充分,但 #13536 在六分钟后落地了完全相同的排版,因此已无差异可合并,我也无从 approve。 退一步看:这是一个来得太晚的好 PR。定位准确,修复用的是最小化的 formatter 输出而非手改,描述里点明了锁定的确切版本,还把 3.6.1 与 3.9.9 的漂移主动标为超出范围,而不是悄悄扩大 diff。如果 之所以不能干脆 approve,是因为批准它等于为一个"已经不再改变任何东西"的改动背书。 因此建议以"被 #13536 取代"为由关闭本 PR。 我没有自行关闭——triage 唯一的自动关闭路径要求存在一个由已合并 PR 关闭(completed)的关联 issue,而本 PR 刻意没有关联 issue,所以该路径不适用。@he-yufeng,如果你认同,由你这边关闭是最干净的收尾;如果你认为本 PR 有 #13536 未覆盖的内容,请说明,我会重跑。 有两点维护者应该看到,都不是这位作者的问题:
本次运行未提交 approve,也没有 approve-on-green 标记——结论是 defer,不是 approve。确定性维护者解析器在这里没有返回结果( — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
📄 Docs-only change — the automatic review ran at
Reviewed head: 中文说明📄 纯文档变更 —— 自动评审以 |
|
Closing: #13536 landed the identical Prettier reformat of 09-event-schema.md on main at 08:29Z, six minutes after this was filed, so there is no delta left to merge. The diagnosis still holds (the lane break was real at filing time); the fix just arrived elsewhere first. |
What this PR does
Reformats the pending-prompt-queue table in
docs/developers/daemon/09-event-schema.mdso the repo passes the Prettier lint lane again. Whitespace and table alignment only, no wording changes.Why it's needed
Current main fails the Prettier gate. #13281 merged a table edit that Prettier 3.6.1 (the version pinned in
pnpm-lock.yaml) rewrites, and the lane checks the whole repo, so every PR that runs the full Lint & Static job goes red. First observed on #13567's CI after it was rebased onto 1753948.Linked Issues
No tracking issue; the regression came in with #13281.
Reviewer Test Plan
How to verify
Run the same command the gate runs:
node scripts/lint.js --prettier(which invokesprettier --experimental-cli --check .). On main it reportsdocs/developers/daemon/09-event-schema.md; on this branch the run is clean.Evidence (Before & After)
Version note: verified with the locked 3.6.1, not a floating 3.x. A floating 3.9.9 restyles 703 files repo-wide and is not what the gate installs from
pnpm-lock.yaml.Tested on
Environment (optional)
Formatting-only change, verified with the gate's own command; no runtime behavior involved.
Risk & Scope
中文说明
重新排版
docs/developers/daemon/09-event-schema.md中的 pending-prompt 队列表格,让仓库重新通过 Prettier lint lane。#13281 合入的表格改动不符合pnpm-lock.yaml锁定的 Prettier 3.6.1 的规则,而该 lane 是全仓检查,导致所有跑完整 Lint & Static 的 PR 全部变红(在 #13567 rebase 到 1753948 之后的 CI 上首次暴露)。用门禁同款命令验证:node scripts/lint.js --prettier,main 上报该文件,本分支全绿。注意必须用锁定的 3.6.1:浮动的 3.9.9 会把全仓 703 个文件重排,并不是门禁实际安装的版本。