Skip to content

ci(desktop-release): run the dependency install step under bash on Windows #12423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yiliang114 wants to merge 1 commit into from
+3 −0
Closed

ci(desktop-release): run the dependency install step under bash on Windows #12423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ci(desktop-release): run the dependency install step under bash on Wi… 
…ndows

The step body is a bash conditional, but this workflow has no defaults.run
block and the step declared no shell, so windows-latest handed it to pwsh and
died with "Missing '(' after 'if'" before npm or pnpm ran. Every later step
skipped, which is why v0.24.2 published no Windows artifact while macOS and
Linux went green.

The nine other bash-bodied steps in this file already declare shell: 'bash'.
This one arrived with the pnpm switch in #11859 and missed it; ci.yml carries
the same snippet safely because it sets defaults.run.shell at workflow level.

Fixes #12414
  • Loading branch information
@yiliang114
yiliang114 committed Sep 21, 2026
commit fb9ab5f03898e19afe09ce1ebfa7c913ed33121d
3 changes: 3 additions & 0 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ jobs:
sudo apt-get install -y libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev libatk-bridge2.0-0 at-spi2-core dbus-x11 patchelf libfuse2 xdg-utils xvfb

- name: 'Install Qwen Code dependencies'
# The body is bash. Without this the Windows runner parses it as pwsh
# and dies before npm or pnpm runs (#12414).
shell: 'bash'
working-directory: '${{ runner.temp }}/qwen-code-source'
env:
QWEN_SKIP_PREPARE: '1'
Expand Down
Loading