Repository navigation
ci(pnpm): install with pnpm everywhere and retire package-lock.json #11859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8aec13a
8e6d195
b5bdc92
584da9c
04610aa
461d3a2
13634af
1402939
44a8a4c
9bccfc9
47c87df
752b6a6
8a7d672
5ff946c
49cc24f
74cbda7
d228113
0d690d6
5b81607
5ee5ce9
15dc732
2a98f36
4b365ae
5a57e23
91ea2c7
0888f5d
fcee577
5f4b8d8
9861c49
88f0030
51aa6fc
166bd8e
7afb34b
34ab9f2
832465e
8905cb5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: 'pnpm store cache' | ||
| description: >- | ||
| Restore and save the pnpm content-addressable store on hosted runners, | ||
| keyed on pnpm-lock.yaml. Self-hosted runners keep their store on local disk | ||
| between jobs, so they do not need this. | ||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: 'Locate the pnpm store' | ||
| id: 'store' | ||
| shell: 'bash' | ||
| run: 'echo "path=$(corepack pnpm store path --silent)" >> "${GITHUB_OUTPUT}"' | ||
|
|
||
| - name: 'Cache the pnpm store' | ||
| uses: 'actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830' # v4.3.0 | ||
| with: | ||
| path: '${{ steps.store.outputs.path }}' | ||
| key: "pnpm-store-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}" | ||
| restore-keys: 'pnpm-store-${{ runner.os }}-' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,7 +123,7 @@ case "${step}" in | |
|
|
||
| push-release-branch) | ||
| release_branch_name="${BRANCH_NAME:?}" | ||
| git add package.json package-lock.json packages/*/package.json packages/channels/*/package.json integrations/*/package.json integrations/*/qwen-extension.json | ||
| git add package.json pnpm-lock.yaml packages/*/package.json packages/channels/*/package.json integrations/*/package.json integrations/*/qwen-extension.json | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified at head Confirmed. The script really does run against the operator-chosen tree rather than the workflow's own: One correction to the ordering, which matters for whoever fixes this: This is the root cause @chiga0 already adjudicated as blocker B3 at Two constraints on the fix, both verified: No patrol code lands this round: size-fused at Leaving this thread unresolved. |
||
| if git diff --staged --quiet; then | ||
| echo "No version changes to commit" | ||
| else | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -699,14 +699,12 @@ jobs: | |
| - uses: 'actions/setup-node@v4' | ||
| with: | ||
| node-version: '22' | ||
| cache: 'npm' | ||
| cache-dependency-path: 'package-lock.json' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| scope: '@qwen-code' | ||
| - name: 'Install npm 11' | ||
| run: 'npm install --global [email protected]' | ||
| - name: 'Install workspace dependencies' | ||
| run: 'npm ci --ignore-scripts --no-audit --no-fund --progress=false' | ||
| run: 'corepack pnpm install --frozen-lockfile --ignore-scripts --prefer-offline --reporter=append-only' | ||
| - name: 'Test standalone Node REPL package' | ||
| working-directory: 'packages/node-repl' | ||
| run: | | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.