Verified review findings from PR #12404 by ytahdn whose fixes lie outside that PR's footprint, deferred by the autofix loop for follow-up. cc @ytahdn. Each rc: item links back to its original review comment. A maintainer or the PR author can turn any item into its own issue/PR and apply the ready-for-agent flow to that issue — nothing here is scheduled automatically.
- ic:5758890221
packages/web-shell/client/e2e/visuals/screenshots.spec.ts: Coverage-gap note from the visuals bot: no mock-daemon scenario seeds a user message carrying inputAnnotations, so the tag-chip CSS change produces no screenshot diff. Adding such a scenario is worth doing; this round relied on the maintainer's real-browser A/B measurements (ic:5761788081) for the visual surface instead.
- rc:4062286436
packages/web-shell/client/App.tsx: Verified by the reviewer's probe: /plan, /skills, and host prepareSubmit paths rewrite the composer text after annotation generation, so submitted offsets go stale and chips fail to render live. That defect pre-exists this PR on the live path; this round's writer-side span validation now also prevents persisting such misaligned pairs. The covering fix (remap or drop annotations wherever App.tsx rewrites the submitted text) is outside this PR's persistence footprint. — comment
Verified review findings from PR #12404 by ytahdn whose fixes lie outside that PR's footprint, deferred by the autofix loop for follow-up. cc @ytahdn. Each rc: item links back to its original review comment. A maintainer or the PR author can turn any item into its own issue/PR and apply the ready-for-agent flow to that issue — nothing here is scheduled automatically.
packages/web-shell/client/e2e/visuals/screenshots.spec.ts: Coverage-gap note from the visuals bot: no mock-daemon scenario seeds a user message carrying inputAnnotations, so the tag-chip CSS change produces no screenshot diff. Adding such a scenario is worth doing; this round relied on the maintainer's real-browser A/B measurements (ic:5761788081) for the visual surface instead.packages/web-shell/client/App.tsx: Verified by the reviewer's probe: /plan, /skills, and host prepareSubmit paths rewrite the composer text after annotation generation, so submitted offsets go stale and chips fail to render live. That defect pre-exists this PR on the live path; this round's writer-side span validation now also prevents persisting such misaligned pairs. The covering fix (remap or drop annotations wherever App.tsx rewrites the submitted text) is outside this PR's persistence footprint. — comment