This repository was archived by the owner on Sep 23, 2026. It is now read-only.
Repository navigation
Conversation
new_client_session() created aiohttp.ClientSession without trust_env=True, so aiohttp ignored HTTP_PROXY/HTTPS_PROXY/NO_PROXY from the environment. Behind a proxy, FetchURL/WebSearch (and every other caller of this helper) failed to reach the network even though curl worked. Set trust_env=True so all outbound requests honour the system proxy. Fixes MoonshotAI#2455
![devin-ai-integration[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Jun 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Behind a proxy,
FetchURL(andWebSearch) fail to reach the network even thoughcurlin the same environment works — withHTTP_PROXY/HTTPS_PROXYset,curl -I https://www.google.comreturns 200 but FetchURL errors out. (Fixes #2455)Root cause
All outbound HTTP goes through
new_client_session()inkimi_cli/utils/aiohttp.py, which builds anaiohttp.ClientSessionwithouttrust_env=True. Unlike curl/httpx, aiohttp ignoresHTTP_PROXY/HTTPS_PROXY/NO_PROXY(and.netrc) from the environment unlesstrust_env=Trueis set, so the proxy is never used.Fix
Set
trust_env=Trueinnew_client_session(). Because every caller (FetchURL, WebSearch, auth, telemetry, …) goes through this single helper, this one change makes them all honour the system proxy.Tests
Added
test_session_trusts_env_for_proxyintests/utils/test_aiohttp_timeout.pyassertingsession.trust_env is True.uv run pytest tests/utils/test_aiohttp_timeout.py→ 4 passed.ruff format/checkclean.