This repository was archived by the owner on Sep 23, 2026. It is now read-only.
Repository navigation
Conversation
Using `assert` for production control flow is unsafe because assertions are stripped when Python runs with the `-O` flag. This replaces the assert that checks `extend` is resolved with a proper `AgentSpecError` exception that is always enforced. Co-Authored-By: Claude Opus 4.7 <[email protected]>
![devin-ai-integration[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert agent_spec.extend is Nonewith a properAgentSpecErrorexception inagentspec.pyWhy
Using
assertfor production control flow is unsafe because Python's-O(optimize) flag strips all assertions, silently disabling this safety check. The assertion guards that recursive agent spec inheritance is fully resolved — if skipped, an unresolvedextendcould propagate and cause confusing downstream errors.The fix replaces the assert with a
raise AgentSpecError(...), which is always enforced regardless of optimization flags.Test plan
tests/related to agent spec loading should continue to passpython -Ono longer silently skips this check🤖 Generated with Claude Code