Repository navigation
Share the DNS timeout budget across deliverability lookups - #178
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
Owner
|
Much of the PR description is gibberish to me. I don't have time to try to guess what it could mean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
timeoutto all DNS lookups for one email address, as requested in #101. Currently, each fallback lookup can use the full timeout again. For example:Compute a deadline with
time.monotonic()and pass the remaining time to each MX, A, AAAA or TXT lookup using dnspython'slifetimeargument. When a resolver is supplied, itslifetimeprovides the initial timeout. Cached answers can still be returned after the time runs out. Resolver backoff and processing can make the total elapsed time exceed the timeout.Evidence
Merge danger
Custom
resolveoverrides must accept thelifetimekeyword argument. Overrides accepting only a domain and record type will fail. The code also stops changing the process-wide default resolver'slifetime. These compatibility changes need maintainer review.Unverified
Live DNS tests were excluded. Hard cancellation, concurrent changes to the resolver, downstream compatibility, packaging, macOS, other Windows versions, Windows coverage HTML and scanner parser coverage were not verified. Hosted CI has no recorded jobs. The full suite was not run with dnspython 2.0.0 because the test fixture requires its missing
CacheKeytype; focused cache and resolver probes passed on that version.