Repository navigation
fix: log field-level execution exceptions with stack traces - #540
Merged
Merged
Conversation
Partial-result field failures were caught into GraphQL errors without calling the schema logger, so Error executing QueryRequest (and the exception stack) disappeared after the 6.x execution refactor. Log via ISchemaProvider.LogException from field catch sites and HandleException. Co-authored-by: Cursor <[email protected]>
…errors
- LogException gets a default (no-op) interface implementation. Adding a
member without one breaks every custom ISchemaProvider, which a patch
release should not do.
- It takes the field name and logs field failures under their own event id and
message ("Error executing field 'x'", FieldError). Reusing the request-level
message meant a query with several root fields could not say which one failed,
and field errors could not be filtered from request errors.
- Document and validation errors are not logged. GenerateErrors returns their
message to the caller in full, so nothing is being swallowed and the request,
not the server, is what went wrong - logging every malformed query at Error is
noise and is trivially remote-triggerable. Ones wrapping a real fault (inner
exception set) are sanitised on the way out, so they are still logged, as are
authorization failures (EntityGraphQLFieldException, not EntityGraphQLException).
- Test for that, and the existing one now asserts the field-named message.
- CHANGELOG entry trimmed and says it is a 6.0 regression.
Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors(partial results in 6.x) now callISchemaProvider.LogException, restoring theError executing QueryRequestlog with the originalException/ stack trace.LogExceptiononISchemaProvider(used byHandleExceptionand field catch sites inExecutableGraphQLStatement).FieldExecutionException_IsLoggedWithException.Test plan
dotnet test --filter FullyQualifiedName~ErrorTests -f net8.0(25 passed)Made with Cursor