Skip to content

[chrome] update since Chrome 155 - #75746

Open
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:chrome-155
Open

[chrome] update since Chrome 155#75746
erwanjugand wants to merge 1 commit into
DefinitelyTyped:masterfrom
erwanjugand:chrome-155

Conversation

@erwanjugand

@erwanjugand erwanjugand commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Please fill in this template.

If changing an existing definition:

Notes:

  • remove chrome.privacy.websites.relatedWebsiteSetsEnabled: chrome remove this API in 155

    image

  • add chrome.runtime.onEnabled event

  • add chrome.tabs.createSplit() function

  • add chrome.tabs.unsplit() function

  • update chrome.tabs.create(): add splitWithTabId key

@typescript-automation

typescript-automation Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@erwanjugand Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 75746,
  "author": "erwanjugand",
  "headCommitOid": "687e56525f65bcb79d66ccc73e6ac6c2b792ea76",
  "mergeBaseOid": "79b2eefd5bf47653f70683236c76d0b2d2b77355",
  "lastPushDate": "2026-10-07T16:27:28.000Z",
  "lastActivityDate": "2026-10-07T20:01:22.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chrome",
      "version": "0.3",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "MatCarlson",
        "JasonXian",
        "usertim",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "nicolas377",
      "date": "2026-10-07T20:01:22.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 6042020432,
  "ciResult": "pass"
}

@typescript-automation typescript-automation Bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Oct 7, 2026
@typescript-automation

typescript-automation Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🔔 @matcarlson @JasonXian @userTim @nicolas377 @idosal @fregante — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@erwanjugand
erwanjugand force-pushed the chrome-155 branch 3 times, most recently from c599e6c to d3f31fc Compare October 7, 2026 16:26
nicolas377
nicolas377 suggested changes Oct 7, 2026
View reviewed changes

@nicolas377 nicolas377 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to feedback re: relatedWebsiteSetsEnabled, but I'd like to at least give a couple extra versions of grace in the types (keeping in mind enterprise folks and others that won't immediately have 155's breaking change rolled to them)

Great change as always.

Comment thread types/chrome/index.d.ts
Comment thread types/chrome/index.d.ts
@typescript-automation typescript-automation Bot added the Revision needed This PR needs code changes before it can be merged. label Oct 7, 2026
@typescript-automation

typescript-automation Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@erwanjugand One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@erwanjugand
erwanjugand requested a review from nicolas377 October 7, 2026 18:52
@typescript-automation typescript-automation Bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Revision needed This PR needs code changes before it can be merged. labels Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nicolas377 nicolas377 nicolas377 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Owner Approved A listed owner of this package signed off on the pull request.

Projects

Pull Request Status Board
Status: Needs Maintainer Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erwanjugand @nicolas377