Repository navigation
[#136] Vault → Write state.json atomically - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #136
Problem
state.jsonis written straight through the vault adapter, so a crash mid write can leave it torn; that file is the common ancestor every sync diffs against, and a torn read already falls back to an empty snapshot, which turns every remotely deleted file into a resurrection and every real divergence into a conflict copyWhy
Greptile Summary
The PR makes persisted vault snapshots crash-safe by staging encoded state in a hidden sibling file and installing it through the existing replacement path.
state.json.Confidence Score: 5/5
The PR appears safe to merge, with snapshot writes now preserving the prior state when installation fails.
The changed store path writes the complete encoded snapshot to a sibling temporary file before invoking the existing replacement logic, while production synchronization serializes store writes and the tests verify prior-state preservation on failure.
Important Files Changed
Reviews (1): Last reviewed commit: "Write state.json atomically" | Re-trigger Greptile
Context used: