Repository navigation
Sync → Flush open editors before reading the vault - #178
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkLocalDriftreads through the Vault API, which only reflects bytes Obsidian has already written to diskWhy
Greptile Summary
This PR flushes pending content from open Markdown editors before sync reads the vault.
flushOpenEditors, which awaits every save-capable Markdown view and propagates save failures.syncOnce.Confidence Score: 5/5
The PR appears safe to merge, with no concrete correctness or security failures identified.
The new flush is awaited before sync begins reading vault content, skips incompatible views, and aborts the sync through its existing error handling if persistence fails.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix editor race" | Re-trigger Greptile
Context used: