Storage → Strictly encode object keys for SigV4 - #129

Resolves #92

Problem

• Object keys were encoded with encodeURIComponent, which leaves ! ' ( ) * bare on the wire, while SigV4 signatures are computed over the strictly encoded RFC 3986 form
• Whether that mismatch breaks depends on how each provider canonicalizes the path before verifying the signature, so a note named Don't forget!.md could fail to sync on some providers with an unexplained per file error

Changes

• Percent encode ! ' ( ) * in object keys and in the prefix and continuation-token list params, so the wire path matches the signed canonical form byte for byte
• Add unit tests for the encoder and an end to end round trip test covering all five characters through put, get, list, and delete

Why

• Apostrophes and parentheses are extremely common in real note names, and sync must be boring for those too
• Strict encoding removes any dependence on provider specific canonicalization, the same choice every AWS SDK makes; verified against MinIO before and after the change

Greptile Summary

This PR fixes a SigV4 signing mismatch by encoding the five characters (! ' ( ) *) that encodeURIComponent leaves bare but RFC 3986 / SigV4 requires to be percent-encoded, ensuring the bytes on the wire match the signed canonical form byte-for-byte across all providers.

• Introduces encodeComponent (a thin wrapper over encodeURIComponent that also encodes the five SigV4-sensitive characters) and wires it into encodeKey and the prefix / continuation-token query parameters in s3ListObjects.
• Adds unit tests for every encoding case and a full end-to-end integration test exercising all five characters through put, get, list, and delete.

Confidence Score: 5/5

Safe to merge — the change is a narrow, well-tested encoding fix with no behavioural regressions for callers.

The percentEncode helper produces the correct %XX form for all five target characters. The regex [!'()*] is a literal character class with no unintended matches. encodeComponent and encodeKey compose cleanly, and the switch in s3ListObjects is the only remaining call site that needed updating. Unit tests cover all encoding cases, and the integration test verifies the full round-trip through a real S3-compatible endpoint.

Files Needing Attention: No files require special attention.

Important Files Changed

_{Reviews (1): Last reviewed commit: "Fix" | Re-trigger Greptile}